Page MenuHome
Differential D3116

Remove Cycles pthreads dependency on Windows
ClosedPublic
Actions

Authored by Jeff Witthuhn (witthuhn) on Mar 27 2018, 8:41 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Group Reviewers
Cycles
Commits
rC28f20177bd20: don't require pthreads as dependency on Windows
rBSbc3a55c3439c: Cycles: don't require pthreads as dependency on Windows.
rBbc3a55c3439c: Cycles: don't require pthreads as dependency on Windows.
Summary

Patch is described in this task: T54431

Diff Detail

Event Timeline

Jeff Witthuhn (witthuhn) created this revision.Mar 27 2018, 8:41 AM
Jeff Witthuhn (witthuhn) updated this revision to Diff 10246.Mar 27 2018, 8:43 AM

Updated to use these changes by default on compatible platforms.

Brecht Van Lommel (brecht) mentioned this in T54431: Add option to build cycles standalone without pthreads on windows.Mar 27 2018, 5:55 PM
Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)
Brecht Van Lommel (brecht) added a reviewer: Cycles.
Brecht Van Lommel (brecht) accepted this revision.Mar 27 2018, 5:58 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

The patch looks good to me. I still need to run some benchmarks with this before committing.

This revision is now accepted and ready to land.Mar 27 2018, 5:58 PM
Closed by commit rBbc3a55c3439c: Cycles: don't require pthreads as dependency on Windows. (authored by Jeff Witthuhn <witthuhn>, committed by Brecht Van Lommel (brecht)). · Explain WhyMar 28 2018, 12:14 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a comment.Mar 28 2018, 12:15 PM

I didn't find any performance impact or Linux or macOS, so committed.

Revision Contents
Changeset List

PathSize
intern/
cycles/
util/
35 lines
14 lines

Diff 10246

View Options

intern/cycles/util/util_thread.h

Loading...
View Options

intern/cycles/util/util_thread.cpp

Loading...