VSE: Remove Add, Sub, Mul effects
Needs RevisionPublic
Actions

Authored by Aaron Carlisle (Blendify) on Apr 20 2018, 2:13 AM.

Details

Reviewers

Sergey Sharybin (sergey)
Campbell Barton (campbellbarton)
Richard Antalik (ISS)

Summary

These were implemented terribly and have been replaced by the color mix
strip

TODO: add versioning for old files to automatically switch to new blend
modes

Diff Detail

Repository

rB Blender

Branch

vse-remove-blendstrips

Build Status

Buildable 1438
Build 1438: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) created this revision.Apr 20 2018, 2:13 AM

If anyone can give me some advice on how to do the versioning code to automatically convert to the new effect type that would be amazing.

I attempted at writing some versioning code however I am not sure if it works because I can't figure out how to write the for loop.

Updates to fix compilation

Aaron Carlisle (Blendify) added a project: BF Blender.Jan 3 2020, 12:07 AM

Aaron Carlisle (Blendify) added a reviewer: Richard Antalik (ISS).

Richard Antalik (ISS) requested changes to this revision.Jan 5 2020, 11:18 PM

Richard Antalik (ISS) added inline comments.

source/blender/blenloader/intern/versioning_270.c
1830 ↗	(On Diff #11121)	You should do conversion in `versioning_280.c` and append last block of the file. I guess this doesn't require bump. if it needed bump, you have to increment value of `BLENDER_SUBVERSION` in `BKE_blender_version.h` and add `if (!MAIN_VERSION_ATLEAST(bmain, 282, last_subversion))` to last block in `versioning_280.c` where `last_subversion` is value of `BLENDER_SUBVERSION` before you modified it.

This revision now requires changes to proceed.Jan 5 2020, 11:18 PM

Yes, the patch does need an update. I was having issue where the old strips were not converted over. I will update the version number and see if it works.

In D3163#153278, @Aaron Carlisle (Blendify) wrote:

Yes, the patch does need an update. I was having issue where the old strips were not converted over. I will update the version number and see if it works.

At the time I reviewed I haven't realized this is very old patch.
You can update this, otherwise I could as well (I say that, but not when...).

We have talked with @Peter Fog (tintwotin) if other effects such as alpha over and under couldn't be included in color mix as well, so we have less of these individual effects (ideally only one).
Not sure if you have any objections to that. Because of T74440 I had a look at math involved, and it looks like these blend modes are strictly dealing with color, so I don't know if it's even appropriate to do it.