Page MenuHome
Differential D3167

Multi-Object-Mode: LATTICE_OT_Select_ungrouped
AbandonedPublic
Actions

Authored by Ian Karanja (ranjian0) on Apr 20 2018, 12:26 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T54647: Multi-Object-Mode: Edit Lattice Tools
Summary

Adds multi-object-mode support for lattice select ungrouped

Diff Detail

Event Timeline

Ian Karanja (ranjian0) created this revision.Apr 20 2018, 12:26 PM
Campbell Barton (campbellbarton) requested changes to this revision.Apr 21 2018, 11:43 PM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/lattice/editlattice_select.c
455

Message should be changed to run at the end of none of the objects have vertex groups.

456

This leaks memory, continue instead.

This revision now requires changes to proceed.Apr 21 2018, 11:43 PM
Campbell Barton (campbellbarton) added inline comments.Apr 22 2018, 9:07 AM
source/blender/editors/lattice/editlattice_select.c
456

Should use: BKE_view_layer_array_from_objects_in_edit_mode_unique_data

Ian Karanja (ranjian0) updated this revision to Diff 10452.EditedApr 23 2018, 8:54 AM

Made changes requested by @Campbell Barton (campbellbarton) .

Issues: Operator only makes selection for objects with vertex groups. This behavior may be non-intuitive depending on what
a user wants to do.

Dalai Felinto (dfelinto) added a task: T54647: Multi-Object-Mode: Edit Lattice Tools.May 9 2018, 12:34 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Oct 24 2018, 1:27 AM

Thanks, committed a similar solution to rBc052d38d0a59478035151af8c5cf9267c7414933.
Your solution was getting RNA_boolean_get inside the for loop by the way.

Dalai Felinto (dfelinto) abandoned this revision.Oct 24 2018, 1:27 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
lattice/
70 lines

Diff 10452

View Options

source/blender/editors/lattice/editlattice_select.c

Loading...