Page MenuHome
Differential D3191

Workbench: Integration VertexPaint and WeightPaint modes
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Apr 30 2018, 3:02 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T54894: Overlay engine: Vertex Paint integration Workbench
Commits
rBScbe57acddf95: Workbench: Integration VertexPaint and WeightPaint modes
rBcbe57acddf95: Workbench: Integration VertexPaint and WeightPaint modes
Summary
  • Disable VertexPaint and WeightPaint for OB_MATERIAL and OB_RENDER. Users want to see the final result
  • When in OB_SOLID, the active object should be rendered without any color. The lighting information is multiplied with the VertexPaint/WeightPaint color
  • Removed the use_shading flag from VertexPaint and WeightPaint
  • add method to check if render engine should draw without color (DRW_object_in_only_lighting_mode)

Diff Detail

Repository
rB Blender
Branch
arcpatch-D3191 (branched from blender2.8)
Build Status
Buildable 1473
Build 1473: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Apr 30 2018, 3:02 PM
Harbormaster completed remote builds in B1472: Diff 10506.Apr 30 2018, 3:02 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Apr 30 2018, 3:04 PM
Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).
Jeroen Bakker (jbakker) added a project: Code Quest.
Jeroen Bakker (jbakker) added a task: T54894: Overlay engine: Vertex Paint integration Workbench.
Clément Foucault (fclem) added inline comments.Apr 30 2018, 3:46 PM
source/blender/draw/intern/DRW_render.h
461

Name it DRW_object_is_paint_mode that would be more accurate and more following other functions naming.

Jeroen Bakker (jbakker) updated this revision to Diff 10507.Apr 30 2018, 3:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2018, 3:55 PM
Closed by commit rBcbe57acddf95: Workbench: Integration VertexPaint and WeightPaint modes (authored by Jeroen Bakker (jbakker)). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
2 lines
source/
blender/
draw/
engines/
workbench/
6 lines
intern/
1 line
15 lines
modes/
8 lines
8 lines

Diff 10507

View Options

release/scripts/startup/bl_ui/space_topbar.py

Loading...
View Options

source/blender/draw/engines/workbench/workbench_materials.c

Loading...
View Options

source/blender/draw/intern/DRW_render.h

Loading...
View Options

source/blender/draw/intern/draw_manager.c

Loading...
View Options

source/blender/draw/modes/paint_vertex_mode.c

Loading...
View Options

source/blender/draw/modes/paint_weight_mode.c

Loading...