Differential D3214

Multi object editing - face dissolve support
ClosedPublic
Actions

Authored by Mateusz (brezdo) on May 7 2018, 9:26 PM.

Tags

Subscribers

Dalai Felinto (dfelinto)

Details

Reviewers

Dalai Felinto (dfelinto)

Maniphest Tasks

T54643: Multi-Object-Mode: EditMesh Tools

Commits

rBS848d9cda0eec: Multi object editing - face dissolve support by Mateusz Grzeliński
rB848d9cda0eec: Multi object editing - face dissolve support by Mateusz Grzeliński

Diff Detail

Event Timeline

Mateusz (brezdo) created this revision.May 7 2018, 9:26 PM

Mateusz (brezdo) added a task: T54643: Multi-Object-Mode: EditMesh Tools.

Thanks for your patch, can you do the following changes:

Remove the RNA_boolean function from the for loop.
Use space and not tab for indentation when breaking a function call.
Continue the for loop when no face is selected for the object you are iterating.

This revision now requires changes to proceed.May 7 2018, 10:02 PM

const bool now outside loop (shame on me…)
Sorry, can not understand you. I have my editor set to spaces, what lines is the issue? (This is Clion's automatic formatting)
Now facecount is checked

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2018, 9:52 AM

Closed by commit rB848d9cda0eec: Multi object editing - face dissolve support by Mateusz Grzeliński (authored by Dalai Felinto (dfelinto)). · Explain Why

This revision was automatically updated to reflect the committed changes.

I fixed the indentation myself. But you can read further about it here: https://wiki.blender.org/index.php/Dev:Doc/Code_Style#Indentation
You can also find some tips to setup some common IDEs here: https://wiki.blender.org/index.php/Dev:Doc/Code_Style/Configuration (Clion is not there).

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

mesh/

editmesh_tools.c

30 lines

Diff 10558

source/blender/editors/mesh/editmesh_tools.c

Loading...