Page MenuHome

Multi-Object-Editing: select_non_manifold (MESH_OT_select_non_manifold)
ClosedPublic

Authored by Jefferson Rausseo (jefrau) on May 8 2018, 4:53 AM.

Diff Detail

Event Timeline

Dalai Felinto (dfelinto) requested changes to this revision.May 8 2018, 11:57 AM

Please address the raised issue, and please check your IDE defaults so it doesn't replace all tabs with spaces:

source/blender/editors/mesh/editmesh_select.c
3962

Remove this check outside the for loop. Have it as a const together with the other RNA_boolean_get() calls.

3970

If it fails for one it will fail for all of them. In this case it is fine to break after reporting, and returning OPERATOR_CANCELLED. Just remember to free objects before exiting the function.

This revision now requires changes to proceed.May 8 2018, 11:57 AM
Jefferson Rausseo (jefrau) marked 2 inline comments as done.

Fixed:

  • Change "continue" for OPERATOR_CANCELLED
  • RNA_boolean_get(op->ptr, "extend") is a const bool.
This revision was not accepted when it landed; it landed in state Needs Review.May 9 2018, 10:04 AM
This revision was automatically updated to reflect the committed changes.

Committed the patch, thanks.