Triangulate modifier port to 2.8
ClosedPublic
Actions

Authored by Christian Hubert (alikendarfen) on May 8 2018, 10:15 AM.

Details

Reviewers

Commits

rBSc67a0580fcd0: Modifiers: ported Triangulate DerivedMesh → Mesh
rBc67a0580fcd0: Modifiers: ported Triangulate DerivedMesh → Mesh

Summary

It seems to be ok, but please have a look to "BKE_mesh_to_bmesh" (line 47) and "BKE_bmesh_to_mesh" (line 51), because I'm not sure to give them the good parameters.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D3237 (branched from blender2.8)

Build Status

Buildable 1519
Build 1519: arc lint + arc unit

Event Timeline

Christian Hubert (alikendarfen) created this revision.May 8 2018, 10:15 AM

Several correction in order to follow the instructions given for boolean (code change the less possible).

Using BKE_mesh_to_bmesh_ex, formatting, ordering of includes.

Harbormaster completed remote builds in B1519: Diff 10735.May 9 2018, 4:13 PM

There were some issues, which I fixed myself. Thanks for your contribution!

source/blender/modifiers/intern/MOD_triangulate.c
33–34	This `#include` is no longer necessary.
37	Keep the #includes grouped, so add `DNA_xxx` files to the already-existing `#include "DNA_xxx"` statements.
49–52	The `DM_to_bmesh` call also calculated normals, which your code does not. Using `BKE_mesh_to_bmesh_ex` here would make more sense.

This revision is now accepted and ready to land.May 9 2018, 4:13 PM

Closed by commit rBc67a0580fcd0: Modifiers: ported Triangulate DerivedMesh → Mesh (authored by Christian Hubert (alikendarfen), committed by Sybren A. Stüvel (sybren)). · Explain WhyMay 9 2018, 4:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

MOD_triangulate.c

37 lines

Diff 10735

View Options

source/blender/modifiers/intern/MOD_triangulate.c

Triangulate modifier port to 2.8ClosedPublicActions