Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 8 2018, 10:58 AM.

Details

Reviewers

Bastien Montagne (mont29)

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) mentioned this in T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..May 8 2018, 11:00 AM

this probably wont merge into 2.8 cleanly [DerivedMesh → Mesh conversion], I guess I'll have to make another version for 2.8 as well [which should only be minimal massage].
CCing @Sybren A. Stüvel (sybren) , just so he knows...

Bastien Montagne (mont29) requested changes to this revision.May 8 2018, 11:42 AM

Bastien Montagne (mont29) added inline comments.

source/blender/blenkernel/intern/lattice.c
874	You forgot to check target is not NULL...
874–889	This should probably rather use `modifier_get_vgroup()` from MOD_util ?

This revision now requires changes to proceed.May 8 2018, 11:42 AM

Sybren A. Stüvel (sybren) awarded a token.May 8 2018, 12:28 PM

missing NULL check

Philipp Oeser (lichtwerk) marked an inline comment as done.May 8 2018, 1:26 PM

Philipp Oeser (lichtwerk) added inline comments.

source/blender/blenkernel/intern/lattice.c
874–889	Not sure I can include MOD_util in blenderkernel? Or should I move `modifier_get_vgroup()` somewhere I can include it? Also: this is just how you did in `curve_deform_verts()` ;) see rB9c95fd0a988f

LGTM

source/blender/blenkernel/intern/lattice.c
874–889	Ouch right, did not saw it was in BKE… then guess patch is OK.

This revision is now accepted and ready to land.May 8 2018, 2:05 PM

commited rB69f2305415a2

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

lattice.c

55 lines

Diff 10602

View Options

source/blender/blenkernel/intern/lattice.c

Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into accountClosedPublicActions