Details

Reviewers

Campbell Barton (campbellbarton)
Clément Foucault (fclem)

Maniphest Tasks

T54983: Implement Bone Selection Overlay

Commits

rBS6d155dc46206: T54983: Bone selection overlay
rB6d155dc46206: T54983: Bone selection overlay

Summary

Bone selection overlay is only available in pose mode.
and when active overrules the selection buffer.

This is currently tricked by switching the draw engines, but this is
an exception. Not sure how to solve this in a better way.

After this is solved we can look at how to localize the dim effect to only the objects connected to the active armatures. Currently it dims the whole screen (including background).

@Campbell Barton (campbellbarton) I added you as reviewer as it you have done a lot in the DRW_draw_select_loop

Diff Detail

Repository

rB Blender

Branch

blender2.8

Build Status

Buildable 1491
Build 1491: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.May 8 2018, 11:27 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)May 8 2018, 11:33 AM

Jeroen Bakker (jbakker) added reviewers: Campbell Barton (campbellbarton), Clément Foucault (fclem).

Jeroen Bakker (jbakker) added projects: BF Blender: 2.8, Code Quest.

Jeroen Bakker (jbakker) added a subscriber: Campbell Barton (campbellbarton).

Jeroen Bakker (jbakker) added a task: T54983: Implement Bone Selection Overlay.May 8 2018, 11:42 AM

Frankly, appart from the style issue it's good to go.

source/blender/draw/intern/draw_manager.c
1597	Typo? precedence?
source/blender/draw/modes/pose_mode.c
83	Code style: Curly Bracket should go to next line.
87	Code Style: use one blank line between functions.

This revision is now accepted and ready to land.May 8 2018, 12:32 PM

Jeroen Bakker (jbakker) marked 3 inline comments as done.May 8 2018, 2:08 PM

D3241: Code style

Harbormaster completed remote builds in B1492: Diff 10612.May 8 2018, 2:09 PM

D3241: only fade out objects that are driven by the active armature

Jeroen Bakker (jbakker) added inline comments.May 8 2018, 11:16 PM

source/blender/draw/modes/pose_mode.c
93	Use default colour shader

D3241: Code cleanup

Merge branch 'blender2.8' into arcpatch-D3241

Harbormaster completed remote builds in B1505: Diff 10684.May 9 2018, 8:21 AM

Closed by commit rB6d155dc46206: T54983: Bone selection overlay (authored by Jeroen Bakker (jbakker)). · Explain WhyMay 11 2018, 8:18 AM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) mentioned this in T66950: Bone Selection problem in weight paint: have to double click bones when obscured by the mesh.Jul 16 2019, 5:18 PM

T54983: Bone selection overlay
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 10607

release/scripts/startup/bl_ui/space_view3d.py

source/blender/draw/CMakeLists.txt

source/blender/draw/intern/draw_manager.c

source/blender/draw/modes/pose_mode.c

source/blender/draw/modes/shaders/pose_bone_selection_frag.glsl

source/blender/editors/armature/armature_intern.h

source/blender/editors/armature/armature_ops.c

source/blender/editors/armature/pose_edit.c

source/blender/makesdna/DNA_scene_types.h

source/blender/makesdna/DNA_view3d_types.h

source/blender/makesrna/intern/rna_space.c

T54983: Bone selection overlayClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10607

release/scripts/startup/bl_ui/space_view3d.py

source/blender/draw/CMakeLists.txt

source/blender/draw/intern/draw_manager.c

source/blender/draw/modes/pose_mode.c

source/blender/draw/modes/shaders/pose_bone_selection_frag.glsl

source/blender/editors/armature/armature_intern.h

source/blender/editors/armature/armature_ops.c

source/blender/editors/armature/pose_edit.c

source/blender/makesdna/DNA_scene_types.h

source/blender/makesdna/DNA_view3d_types.h

source/blender/makesrna/intern/rna_space.c

T54983: Bone selection overlay
ClosedPublic
Actions

Revision Contents
Changeset List