Paths

Table of Contentst

Differential D3253

Edit Mesh: multi-object MESH_OT_loop_to_region support
ClosedPublic
Actions

Authored by Oleg (DotBow) on May 8 2018, 7:53 PM.

Tags

Subscribers

None

Details

Reviewers

Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)

Maniphest Tasks

T54643: Multi-Object-Mode: EditMesh Tools

Commits

rBS8b41999ea0ff: Multi-Object: MESH_OT_loop_to_region by Oleg
rB8b41999ea0ff: Multi-Object: MESH_OT_loop_to_region by Oleg

Summary

Support for multi-object edge loop to face region selection. T54643

Diff Detail

Repository: rB Blender

Event Timeline

Oleg (DotBow) created this revision.May 8 2018, 7:53 PM

Oleg (DotBow) edited the summary of this revision. (Show Details)May 8 2018, 10:09 PM

Dalai Felinto (dfelinto) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 9 2018, 12:40 PM

Dalai Felinto (dfelinto) requested changes to this revision.May 9 2018, 1:01 PM

Dalai Felinto (dfelinto) added inline comments.

source/blender/editors/mesh/editmesh_select.c
4480	Move the '{' to the previous line. We only have it in a new line where there is a multi-line if/else. In the example commit we did break this rule just to keep the example simple (since we didn't change indentation there for clarity).
4490	Move `RNA.*_get` outside the for loop.

This revision now requires changes to proceed.May 9 2018, 1:01 PM

"Move the '{' to the previous line" done.
"Move RNA.*_get outside the for loop" done.

This revision was not accepted when it landed; it landed in state Needs Review.May 11 2018, 11:36 AM

Closed by commit rB8b41999ea0ff: Multi-Object: MESH_OT_loop_to_region by Oleg (authored by Dalai Felinto (dfelinto)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Thanks, committed.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

mesh/

editmesh_select.c

49 lines

Diff 10631

source/blender/editors/mesh/editmesh_select.c

Loading...