Adds multi-object support for 'snap to symmetry' as part of task T54643 (Multi-Object-Mode: EditMesh Tools)
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- blender2.8
- Build Status
Buildable 1500 Build 1500: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for your patch but it needs a few changes to proceed. See in-line comments.
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 6476 | 'const' variables that are not related to the mesh, and in particular RNA.*get functions should be moved outside the for loop. | |
| 6551 | Errors should only be reported once, and only if all the objects fall into this error. That also means that for single object editing it should behave as before. | |
Comment Actions
I moved the constant and variables that do not depend on the mesh outside of the loop and moved the report to outside the multi-object loop.
Now it will only report the statistics once and these stats will be the total over all objects. If one vertex fails on one object, but all other objects have no failures, the failure will still be reported.
Also, I moved the memory allocation to after the check of whether to skip the object, to prevent memory leaks.
I also renamed the variables to be clear that they refer to vertices and not objects.
Comment Actions
The patch is failing to apply. Can you please re-submit it with arcanist?
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist
Comment Actions
I've resubmitted this diff as D3374. I think the issue was that I had diffed from master and not blender2.8.