Page MenuHome
Differential D3269

Multi-Object-Editing : Support for MESH_OT_screw
AbandonedPublic
Actions

Authored by Nick Milios (semaphore) on May 9 2018, 2:07 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools

Diff Detail

Repository
rB Blender

Event Timeline

Nick Milios (semaphore) created this revision.May 9 2018, 2:07 AM
Nick Milios (semaphore) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 9 2018, 4:15 AM
Dalai Felinto (dfelinto) requested changes to this revision.May 9 2018, 11:55 AM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

The patch needs the following changes:

  • Move RNA_int_get outside the for loop.
  • Continue the for loop when there is less than 2 selected vertices.

And you shouldn't print the error message (BKE_report) for every object. It should be printed only if the operator fails for all of them and for that particular reason.

This revision now requires changes to proceed.May 9 2018, 11:55 AM
Nick Milios (semaphore) updated this revision to Diff 10723.May 9 2018, 3:06 PM

Fix the recommended instructions.

    • RNA_*get* calls out of loop
    • Continue when total vertices < 2
  • Report the same errors when all objects with at least one vertex selected failed for the same reason.

(e.x. when we have 2 Objects in edit mode and only one has some selections that are invalid we need to throw the error otherwise it will be confusing with bad consistency)

Dalai Felinto (dfelinto) added a comment.May 11 2018, 11:26 AM

Thanks, committed with a few changes.

Dalai Felinto (dfelinto) abandoned this revision.May 11 2018, 11:28 AM

Ops tagged the wrong patch during commit. This was committed on: rBbadd88ca024c78b5d64579404f95abf2103f7b25

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
142 lines

Diff 10654

View Options

source/blender/editors/mesh/editmesh_extrude_screw.c

Loading...