Added select loose to multi edit mode.
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on May 9 2018, 2:49 AM.

Details

Reviewers

Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)

Maniphest Tasks

T54643: Multi-Object-Mode: EditMesh Tools

Commits

rBSbadd88ca024c: Multi-Object: MESH_OT_screw by Nick Milios
rBSeacb2eb42349: Multi-Object: MESH_OT_select_loose by Falk David
rBbadd88ca024c: Multi-Object: MESH_OT_screw by Nick Milios
rBeacb2eb42349: Multi-Object: MESH_OT_select_loose by Falk David

Diff Detail

Repository

rB Blender

Branch

select_loose_multi_edit_mode (branched from blender2.8)

Build Status

Buildable 1501
Build 1501: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) created this revision.May 9 2018, 2:49 AM

Harbormaster completed remote builds in B1501: Diff 10662.May 9 2018, 2:49 AM

Falk David (filedescriptor) added reviewers: Dalai Felinto (dfelinto), Campbell Barton (campbellbarton).May 9 2018, 2:51 AM

Falk David (filedescriptor) added a project: BF Blender: 2.8.

Falk David (filedescriptor) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 9 2018, 3:40 AM

Thanks for you contribution. This patch needs a few changes to be committed though:

Proper indentation (you are using space instead of tab for padding, see:
https://wiki.blender.org/index.php/Dev:Doc/Code_Style#Indentation
https://wiki.blender.org/index.php/Dev:Doc/Code_Style/Configuration

Move RNA_boolean_get outside the for loop.

This revision now requires changes to proceed.May 9 2018, 11:00 AM

Ah, and please remove the indentation changes in unified_findnearest, since this seems to have slip in the patch.

Requested changes have been made.

This revision was not accepted when it landed; it landed in state Needs Review.May 11 2018, 11:13 AM

Closed by commit rBeacb2eb42349: Multi-Object: MESH_OT_select_loose by Falk David (authored by Dalai Felinto (dfelinto)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Thank you, committed.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

mesh/

editmesh_select.c

104 lines

Diff 10662

View Options

source/blender/editors/mesh/editmesh_select.c

Added select loose to multi edit mode.ClosedPublicActions