Multi object editing - 18 task completed
Needs ReviewPublic
Actions

Authored by Jaed Al Zaber (jaedalzaber) on May 9 2018, 6:10 AM.

Details

Reviewers

Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)

Summary

Mesh toolbar about 18 task completed

MESH_OT_convex_hull
MESH_OT_fill_grid
MESH_OT_normals_make_consistent
MESH_OT_offset_edge_loops
MESH_OT_screw
MESH_OT_select_axis
MESH_OT_select_face_by_sides
MESH_OT_select_interior_faces
MESH_OT_select_linked_pick
MESH_OT_select_loose
MESH_OT_select_mirror
MESH_OT_select_non_manifold
MESH_OT_select_nth
MESH_OT_select_similar
MESH_OT_select_similar_region
MESH_OT_select_ungrouped
MESH_OT_vert_connect
MESH_OT_vert_connect_path

Diff Detail

Event Timeline

Jaed Al Zaber (jaedalzaber) created this revision.May 9 2018, 6:10 AM

Jaed Al Zaber (jaedalzaber) updated this revision to Diff 10677.May 9 2018, 6:19 AM

Jaed Al Zaber (jaedalzaber) edited the summary of this revision. (Show Details)

Jaed Al Zaber (jaedalzaber) added a reviewer: Campbell Barton (campbellbarton).

Jaed Al Zaber (jaedalzaber) removed rB Blender as the repository for this revision.

Jaed Al Zaber (jaedalzaber) added a project: Modeling.

Jaed Al Zaber (jaedalzaber) added a task: T54643: Multi-Object-Mode: EditMesh Tools.

Jaed Al Zaber (jaedalzaber) added a subscriber: Modeling.

Jaed Al Zaber (jaedalzaber) edited the summary of this revision. (Show Details)May 9 2018, 6:25 AM

Jaed Al Zaber (jaedalzaber) retitled this revision from Multi object editing to Multi object editing - 18 task completed.May 9 2018, 8:10 AM

Jaed Al Zaber (jaedalzaber) removed a task: T54643: Multi-Object-Mode: EditMesh Tools.May 9 2018, 11:09 AM

Jaed Al Zaber (jaedalzaber) removed reviewers: Dalai Felinto (dfelinto), Campbell Barton (campbellbarton).

Jaed Al Zaber (jaedalzaber) changed the visibility from "Public (No Login Required)" to "No One".

Jaed Al Zaber (jaedalzaber) removed a project: Modeling.

Jaed Al Zaber (jaedalzaber) removed a subscriber: Modeling.

Jaed Al Zaber (jaedalzaber) updated this revision to Diff 10765.May 10 2018, 7:45 AM

Jaed Al Zaber (jaedalzaber) added reviewers: Dalai Felinto (dfelinto), Campbell Barton (campbellbarton).

Jaed Al Zaber (jaedalzaber) changed the visibility from "No One" to "Public (No Login Required)".

Jaed Al Zaber (jaedalzaber) added a project: Modeling.May 10 2018, 7:47 AM

Jaed Al Zaber (jaedalzaber) added a task: T54643: Multi-Object-Mode: EditMesh Tools.

@Dalai Felinto (dfelinto) i have done few tasks all together, but is it better to submit the tasks one by one for review?

It definitively better to submit them individually, yes. Also important, there are a few mistakes in your patch, let me add them as inline comments.

source/blender/editors/mesh/editmesh_tools.c
4117	Operators such as this one should skip the for loop when there is no selected vert, edge and/or face. It depends on the operator what to use and whether is required (e.g., reveal faces don't require that, hide faces require to test for all three of them, inset requires selected faces, ...)
6427	RNA_.*_get functions should be moved outside the for loop.

Ok, got it. i will remove this review and upload each task separately. looks like some of them are already done. its hard know which operator use vert,edge and/or faces, cause i'm not familiar with all of the operators, but i will try to fix them at my best :)

Jaed Al Zaber (jaedalzaber) removed a task: T54643: Multi-Object-Mode: EditMesh Tools.May 10 2018, 2:12 PM

Dalai Felinto (dfelinto) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 14 2018, 2:48 PM

Dalai Felinto (dfelinto) removed a task: T54643: Multi-Object-Mode: EditMesh Tools.May 14 2018, 3:35 PM