Details

Reviewers

Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Commits

rBSc0667c2f35a1: T55008: Migrating RE-Collection data to Scene data
rBc0667c2f35a1: T55008: Migrating RE-Collection data to Scene data

Summary

in Scene DNA is available in scene.display New DNA Struct DisplayData
Added RNA (scene.display).

We already have scene.display_settings which contains non viewpoert
specific color management settings. I did not merge those two.

Patch should be in line with the ideas that @Brecht Van Lommel (brecht) wrote in T55008.

As I am not in detail aware of the decisions that have been made for the override feature I want a short review if it is in line with the plans.

Diff Detail

Repository

rB Blender

Branch

blender2.8

Build Status

Buildable 1509
Build 1509: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.May 9 2018, 10:02 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)May 9 2018, 10:06 AM

Jeroen Bakker (jbakker) added reviewers: Brecht Van Lommel (brecht), Dalai Felinto (dfelinto).

Jeroen Bakker (jbakker) added projects: Code Quest, BF Blender: 2.8.

Jeroen Bakker (jbakker) added a subscriber: Brecht Van Lommel (brecht).

I don't think these random color settings should be in the scene. They could be a 3D view theme option perhaps, but I'm not sure we need them at all?

release/scripts/startup/bl_ui/properties_render.py
746	I think this belongs in the Scene tab rather than the Render tab.
source/blender/editors/space_view3d/space_view3d.c
1092–1094	You can subscribe to the entire struct, individual properties seem unnecessary in this case.
source/blender/makesdna/DNA_scene_types.h
1358	Call this `SceneDisplay`, so it's clear this is for the scene, `DisplayData` is too generic.

This revision now requires changes to proceed.May 9 2018, 10:19 AM

D3290: updated the versioning code

@Brecht Van Lommel (brecht) I solved your comments. I also removed the random_color_* properties. I used them to determine defaults but that is not needed anymore.

Merge branch 'blender2.8' into arcpatch-D3290
D3290: resolved review comments

Harbormaster completed remote builds in B1512: Diff 10704.May 9 2018, 12:55 PM

D3290: Missed renaming in comment

Brecht Van Lommel (brecht) accepted this revision.May 9 2018, 1:00 PM

This revision is now accepted and ready to land.May 9 2018, 1:00 PM

Brecht Van Lommel (brecht) added inline comments.May 9 2018, 1:01 PM

source/blender/makesrna/intern/rna_scene.c
5649	This function could be renamed still.
5657	`"Scene Display", "Scene display settings for the 3d viewport"`
6149	`"Scene Display", "Scene display settings for the 3d viewport"`

D3290: solved RNA comments

Harbormaster completed remote builds in B1514: Diff 10712.May 9 2018, 1:31 PM

Closed by commit rBc0667c2f35a1: T55008: Migrating RE-Collection data to Scene data (authored by Jeroen Bakker (jbakker)). · Explain WhyMay 9 2018, 1:40 PM

This revision was automatically updated to reflect the committed changes.

T55008: Migrating RE-Collection data to Scene data
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 10689

release/scripts/startup/bl_ui/properties_render.py

source/blender/blenkernel/intern/scene.c

source/blender/blenloader/intern/versioning_280.c

source/blender/draw/engines/workbench/workbench_engine.c

source/blender/draw/engines/workbench/workbench_materials.c

source/blender/editors/space_view3d/space_view3d.c

source/blender/makesdna/DNA_scene_types.h

source/blender/makesrna/RNA_access.h

source/blender/makesrna/intern/rna_layer.c

source/blender/makesrna/intern/rna_scene.c

T55008: Migrating RE-Collection data to Scene dataClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10689

release/scripts/startup/bl_ui/properties_render.py

source/blender/blenkernel/intern/scene.c

source/blender/blenloader/intern/versioning_280.c

source/blender/draw/engines/workbench/workbench_engine.c

source/blender/draw/engines/workbench/workbench_materials.c

source/blender/editors/space_view3d/space_view3d.c

source/blender/makesdna/DNA_scene_types.h

source/blender/makesrna/RNA_access.h

source/blender/makesrna/intern/rna_layer.c

source/blender/makesrna/intern/rna_scene.c

T55008: Migrating RE-Collection data to Scene data
ClosedPublic
Actions

Revision Contents
Changeset List