This is my first contribution, if there is an issue I'll gladly fix it :)
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Hi, thanks for your patch. There are a few things that need to change though:
- RNA_.*_get functions should be kept outside the for loop.
- Code style (comments inline) see:
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 4288 | Move the { to the previous line with a space between the parenthesis and the brackets. It is only in different lines in the example commit to keep the example file simpler (so no indentation was changed there). | |
| 4293 | No const need to be in the for loop unless related to the object in question. | |
| 4316 | Don't use tabs here, use spaces instead (for the padding relative to the "if" line). | |
| 4321 | Only separate the if/else from the bracket if it is a multi-line if/else statement. | |
Comment Actions
Thanks for the feedback! I'll have a good look at the coding style before a next contribution...
I think the code should be okay now though
Comment Actions
Re-added space after BM_ITER_MESH and kept the continue in EDBM_op_call_and_selectf for consistency
Comment Actions
All good now. Actually I forgot to tell you to include a test for selected faces. I did that change in the final commit, check the commit to see the differences.
Thanks for your contribution.