Details
- Reviewers
Campbell Barton (campbellbarton) Dalai Felinto (dfelinto) - Maniphest Tasks
- T54643: Multi-Object-Mode: EditMesh Tools
Diff Detail
- Repository
- rB Blender
- Branch
- blender2.8
- Build Status
Buildable 1515 Build 1515: arc lint + arc unit
Event Timeline
This one is tricky because edbm_vert_connect_exec also loops over all the objects.
My suggestion, move the logic to handle vert_connect to its own function, and make it accessible by both operators.
And you don't really want to break if one of the vert_connect calls fail.
I see. I'll have some time this afternoon and then I will try and see what I can do.
And yes, thinking about it, the break is unnecessary.
I have created a new function bm_connect_vert_pair (other name suggestions are welcome!) that basically does the same as edbm_vert_connect_exec before multi object edit. Then I used it in the new edbm_vert_connect_exec and also edbm_vert_connect_path_exec so that each operator only loops through the objects once.
Applying the patch is failing at the moment, could you please rebase with blender2.8 and re-submit using arcanist?
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist
I will abandon this then. For the records you could have updated it with arc diff origin/blender2.8 --update D3293.