Page MenuHome
Differential D3294

Multi-Object-Edit : MESH_OT_select_similar_region
Needs ReviewPublic
Actions

Authored by Philippe Bachour (philippe-bachour) on May 9 2018, 2:53 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Summary

Support for select similar region in multi object edit.

Diff Detail

Repository
rB Blender

Event Timeline

Philippe Bachour (philippe-bachour) created this revision.May 9 2018, 2:53 PM
Dalai Felinto (dfelinto) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 14 2018, 2:48 PM
Dalai Felinto (dfelinto) requested changes to this revision.May 14 2018, 3:19 PM

Thanks for your contribution. Your patch needs a few changes to proceed though.
Please see in-line comments for details.

source/blender/editors/mesh/editmesh_select.c
1343

Move { to the previous line, with a space after the ( with a space between them.

1348

Skip the for loop when no selected relevant element (face in this case I suppose?).

1357

Report errors only once and only if all the objects have the same error.

1409

Report errors only once and only if all the objects have the same error.

This revision now requires changes to proceed.May 14 2018, 3:19 PM
Philippe Bachour (philippe-bachour) updated this revision to Diff 11009.EditedMay 17 2018, 3:21 PM

I've updated the diff according to your comments

  • Indentation fixed
  • Skip the for loop when no selected relevant element
  • Report errors only once and only if all the objects have the same error.

By the way, shouldn't it work across objects, the same way you want select_similar to work ? D3310

Philippe Bachour (philippe-bachour) updated this revision to Diff 11017.May 17 2018, 9:09 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
107 lines

Diff 10722

View Options

source/blender/editors/mesh/editmesh_select.c

Loading...