Page MenuHome
Differential D3300

Multi-Object-Mode : MESH_OT_bevel
AbandonedPublic
Actions

Authored by Philippe Bachour (philippe-bachour) on May 9 2018, 4:08 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Summary

Support for bevel in multi object edit mode.

I added the BKE_layer include, changed the signature of edbm_bevel_calc and updated function calls

Diff Detail

Repository
rB Blender

Event Timeline

Philippe Bachour (philippe-bachour) created this revision.May 9 2018, 4:08 PM
Nick Milios (semaphore) added a subscriber: Nick Milios (semaphore).EditedMay 9 2018, 5:13 PM

Is it working?

source/blender/editors/mesh/editmesh_bevel.c
159

This line overrides opdata->em BMEditMesh to the last object of for loop.
So when edbm_bevel_calc is called it uses the second object twice.
Is it working?

Philippe Bachour (philippe-bachour) updated this revision to Diff 10743.May 9 2018, 7:25 PM

Memory allocation at op->customdata to have per object BevelData
Updated ebdm_bevel_cancel to support multi object edit
Updated ebdm_bevel_exit to free op->customdata

Philippe Bachour (philippe-bachour) added a comment.May 9 2018, 7:28 PM

Yes @Nick Milios (semaphore) you're right, I didn't read the code and tested enough, it wasn't working correctly for objects with different scales for example, thank you for pointing that out :)

Nick Milios (semaphore) added a comment.May 9 2018, 8:42 PM

When
https://developer.blender.org/D3247
or
https://developer.blender.org/D3305
will be accepted, we can do MESH_OT_bevel and MESH_OT_knife_tool the same way.

Philippe Bachour (philippe-bachour) added a reviewer: Campbell Barton (campbellbarton).May 11 2018, 3:52 PM
Dalai Felinto (dfelinto) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 14 2018, 2:48 PM
Dalai Felinto (dfelinto) requested changes to this revision.May 14 2018, 3:05 PM
Dalai Felinto (dfelinto) added inline comments.
source/blender/editors/mesh/editmesh_bevel.c
137

See comments on D3247 re: MEM_callocN and to see the final committed patch.

149

It can't return, it should continue

153

RNA_.*get/set should be outside the for loop.

This revision now requires changes to proceed.May 14 2018, 3:05 PM
Philippe Bachour (philippe-bachour) abandoned this revision.May 17 2018, 3:44 PM

Already done in D3352

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
217 lines

Diff 10734

View Options

source/blender/editors/mesh/editmesh_bevel.c

Loading...