Page MenuHome
Differential D3302

Multi object edit: VIEW3D_OT_snap_selected_to_grid
ClosedPublic
Actions

Authored by Leon Eckardt (Leon95) on May 9 2018, 6:28 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Commits
rBS016ba0f38bfc: Multi-Objects: VIEW3D_OT_snap_selected_to_gri by Leon Eckardtd
rB016ba0f38bfc: Multi-Objects: VIEW3D_OT_snap_selected_to_gri by Leon Eckardtd
Summary

Adds Multi object edit support for VIEW3D_OT_snap_selected_to_grid
See T54643

Diff Detail

Repository
rB Blender
Branch
arcpatch-D3302 (branched from blender2.8)
Build Status
Buildable 1541
Build 1541: arc lint + arc unit

Event Timeline

Leon Eckardt (Leon95) created this revision.May 9 2018, 6:28 PM
Leon Eckardt (Leon95) added a task: T54643: Multi-Object-Mode: EditMesh Tools.
Dalai Felinto (dfelinto) requested changes to this revision.May 11 2018, 11:54 AM

Applying the patch is failing at the moment, could you please rebase with blender2.8 and re-submit using arcanist?
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist

This revision now requires changes to proceed.May 11 2018, 11:54 AM
Leon Eckardt (Leon95) updated this revision to Diff 10814.May 11 2018, 12:56 PM

Update with arc. Hope It works now.

Harbormaster completed remote builds in B1540: Diff 10814.May 11 2018, 12:56 PM
Leon Eckardt (Leon95) updated this revision to Diff 10815.May 11 2018, 1:11 PM
  • Reformat
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2018, 12:53 PM
Closed by commit rB016ba0f38bfc: Multi-Objects: VIEW3D_OT_snap_selected_to_gri by Leon Eckardtd (authored by Dalai Felinto (dfelinto)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a comment.May 14 2018, 12:54 PM

Committed with changes:

  • Keep include header in alphabetical order within their "namespace".
  • Skip for loop when no selected vert/edge/face.

For future patches if you want I can have the patch authored by you (using your name/email) as submitted by arc.

Leon Eckardt (Leon95) mentioned this in D3425: Multi-Objects: VIEW3D_OT_snap_selected_to_cursor.Jul 15 2018, 1:41 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_view3d/
55 lines

Diff 10815

View Options

source/blender/editors/space_view3d/view3d_snap.c

Loading...