Page MenuHome
Differential D3303

Decimate modifier port to 2.8
ClosedPublic
Actions

Authored by Christian Hubert (alikendarfen) on May 9 2018, 6:30 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Commits
rBSe0a41fd0ced5: Modifiers: ported Decimate DerivedMesh → Mesh
rBe0a41fd0ced5: Modifiers: ported Decimate DerivedMesh → Mesh
Summary

Two things to indicate which are true too before the port in blender2.8 branch:

  • face count in the UI is not updated and stay to 0
  • when planar mode is used, the result is inverted (mirrored along X) compared to 2.79

Diff Detail

Repository
rB Blender
Branch
arcpatch-D3303 (branched from blender2.8)
Build Status
Buildable 1538
Build 1538: arc lint + arc unit

Event Timeline

Christian Hubert (alikendarfen) created this revision.May 9 2018, 6:30 PM
Sybren A. Stüvel (sybren) accepted this revision.May 11 2018, 11:07 AM
Sybren A. Stüvel (sybren) added inline comments.
source/blender/modifiers/intern/MOD_decimate.c
156

Make sure your indentations are correct. It's currently this:

but should be this:

(arrow = tab, dot = space)

188

No space before {0}

This revision is now accepted and ready to land.May 11 2018, 11:07 AM
Sybren A. Stüvel (sybren) updated this revision to Diff 10805.May 11 2018, 11:08 AM
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)
  • Fixed formatting
Harbormaster completed remote builds in B1538: Diff 10805.May 11 2018, 11:08 AM
Closed by commit rBe0a41fd0ced5: Modifiers: ported Decimate DerivedMesh → Mesh (authored by Christian Hubert (alikendarfen), committed by Sybren A. Stüvel (sybren)). · Explain WhyMay 11 2018, 11:13 AM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) mentioned this in T54737: Modifiers: Convert from DerivedMesh → Mesh.May 11 2018, 11:13 AM

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
41 lines

Diff 10805

View Options

source/blender/modifiers/intern/MOD_decimate.c

Loading...