Page MenuHome
Differential D3305

Multi-Object-Mode: MESH_OT_inset
ClosedPublic
Actions

Authored by Jean-François Michaud (jfmichaud31) on May 9 2018, 8:12 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)
Summary

Inset Faces tool updated for multi-object mode.

Diff Detail

Repository
rB Blender

Event Timeline

Jean-François Michaud (jfmichaud31) created this revision.May 9 2018, 8:12 PM
Jean-François Michaud (jfmichaud31) added a reviewer: Dalai Felinto (dfelinto).May 9 2018, 8:38 PM
Jean-François Michaud (jfmichaud31) added a subscriber: Dalai Felinto (dfelinto).
Jean-François Michaud (jfmichaud31) removed a subscriber: Dalai Felinto (dfelinto).
Campbell Barton (campbellbarton) requested changes to this revision.May 11 2018, 9:03 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

Thanks for the patch, looks good, only minor change needed.

source/blender/editors/mesh/editmesh_inset.c
286

This prevents others from executing, return value should be made into a variable, true if any succeed.

This revision now requires changes to proceed.May 11 2018, 9:03 AM
Jean-François Michaud (jfmichaud31) updated this revision to Diff 10827.May 11 2018, 5:27 PM

Added variable ret for return. Returns true if any operation succeeded. If one operation fails continue to the next object.

Campbell Barton (campbellbarton) mentioned this in rB570455fb83a3: EditMode: multi-object inset.May 12 2018, 11:01 AM
Campbell Barton (campbellbarton) accepted this revision.May 12 2018, 12:09 PM

Thanks, committed rB570455fb83a3208d5e7653f22b0e14430a8774f0

This revision is now accepted and ready to land.May 12 2018, 12:09 PM
Campbell Barton (campbellbarton) closed this revision.May 12 2018, 12:09 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
141 lines

Diff 10745

View Options

source/blender/editors/mesh/editmesh_inset.c

Loading...