Details
Details
Diff Detail
Diff Detail
Event Timeline
| source/blender/editors/mesh/editmesh_intersect.c | ||
|---|---|---|
| 270 | i missed that | |
Comment Actions
As commented on D3307:
- Missing freeing objects.
- Missing skip when no relevant element is selected (or is this not relevant in this case?)
Comment Actions
The patch is failing to apply. Can you please re-submit it with arcanist?
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist
Use --update D3306 to update this patch instead of adding a new one.
Comment Actions
- Updating D3306: Multi-Object-Editing: intersect boolean (MESH_OT_intersect_boolean) #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
Rebase using arc
Comment Actions
Committed, by the way I had to fix the skip test.
You were checking for totvert (never relevant by the way, totvertsel is what you meant I suppose), but in this case it should be totfacesel.
Thanks for your contribution.