⚙ D3307 Multi-Object-Editing: intersect (MESH_OT

Nick Milios (semaphore) created this revision.May 9 2018, 9:09 PM

Nick Milios (semaphore) added inline comments.May 9 2018, 9:36 PM

source/blender/editors/mesh/editmesh_intersect.c
150	i missed that

Nick Milios (semaphore) updated this revision to Diff 10757.May 9 2018, 11:07 PM

Nick Milios (semaphore) updated this revision to Diff 10758.

Nick Milios (semaphore) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 9 2018, 11:29 PM

Nick Milios (semaphore) retitled this revision from Multi-Object-Editing: Inset (MESH_OT_intersect) to Multi-Object-Editing: intersect (MESH_OT_intersect).May 10 2018, 1:34 PM

Missing freeing objects.
Missing skip when no relevant element is selected (or is this not relevant in this case?)

This revision now requires changes to proceed.May 11 2018, 12:18 PM

Dalai Felinto (dfelinto) mentioned this in D3306: Multi-Object-Editing: intersect boolean (MESH_OT_intersect_boolean).May 11 2018, 12:19 PM

Nick Milios (semaphore) updated this revision to Diff 10821.May 11 2018, 3:51 PM

The patch is failing to apply. Can you please re-submit it with arcanist?
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist

This revision now requires changes to proceed.May 14 2018, 12:59 PM

rebase using arc

need rebase in contrast with intersect boolean

trying rebase

failed

Rebase to 2.8

This revision was not accepted when it landed; it landed in state Needs Review.May 16 2018, 12:17 PM

Closed by commit rBdffd37877d17: Multi-Object-Editing: intersect (MESH_OT_intersect) (authored by Nick Milios (semaphore), committed by Dalai Felinto (dfelinto)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Multi-Object-Editing: intersect (MESH_OT_intersect)
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 10938

source/blender/editors/mesh/editmesh_intersect.c

Multi-Object-Editing: intersect (MESH_OT_intersect)ClosedPublicActions