Page MenuHome
Differential D3308

Multi-Object-Editing: Weld Edges into Faces(MESH_OT_face_split_by_edges)
ClosedPublic
Actions

Authored by Nick Milios (semaphore) on May 9 2018, 9:26 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Commits
rBSb6a822d72623: Multi-Object-Editing: Weld Edges into Faces(MESH_OT_face_split_by_edges)
rBb6a822d72623: Multi-Object-Editing: Weld Edges into Faces(MESH_OT_face_split_by_edges)

Diff Detail

Event Timeline

Nick Milios (semaphore) created this revision.May 9 2018, 9:26 PM
Nick Milios (semaphore) added inline comments.May 9 2018, 9:35 PM
source/blender/editors/mesh/editmesh_intersect.c
676

i missed that

Nick Milios (semaphore) added inline comments.May 9 2018, 10:13 PM
source/blender/editors/mesh/editmesh_intersect.c
686

and that.
how can i combine two git commits to one patch?

Nick Milios (semaphore) updated this revision to Diff 10752.May 9 2018, 10:14 PM
Nick Milios (semaphore) planned changes to this revision.May 9 2018, 10:29 PM
Nick Milios (semaphore) updated this revision to Diff 10755.May 9 2018, 11:02 PM
Nick Milios (semaphore) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 9 2018, 11:28 PM
Dalai Felinto (dfelinto) requested changes to this revision.May 11 2018, 12:17 PM
Dalai Felinto (dfelinto) added inline comments.
source/blender/editors/mesh/editmesh_intersect.c
686

Shouldn't you skip (continue) the for loop when no edge nor face is selected? (totedgesel == 0) || (totvertsel == 0)

932–933

Missing MEM_freeN(objects).

This revision now requires changes to proceed.May 11 2018, 12:17 PM
Nick Milios (semaphore) updated this revision to Diff 10822.May 11 2018, 3:55 PM
Nick Milios (semaphore) marked 2 inline comments as done.
Nick Milios (semaphore) marked 2 inline comments as done.May 13 2018, 9:27 PM
Dalai Felinto (dfelinto) requested changes to this revision.May 14 2018, 12:58 PM

The patch is failing to apply. Can you please re-submit it with arcanist?
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist

That also allows me to just submit the patch, but have it properly credited to you.

This revision now requires changes to proceed.May 14 2018, 12:58 PM
Nick Milios (semaphore) updated this revision to Diff 10941.May 15 2018, 3:14 PM
Nick Milios (semaphore) retitled this revision from Multi-Object-Editing: Weld Edges into Faces(MESH_OT_face_split_by_edges) to Multi-Object-Editing: Weld Edges into Faces(MESH_OT_face_split_by_edges).

rebase 2.8

Dalai Felinto (dfelinto) added a comment.May 16 2018, 11:56 AM

Thanks you , committed.

This revision was not accepted when it landed; it landed in state Needs Review.May 16 2018, 11:56 AM
Closed by commit rBb6a822d72623: Multi-Object-Editing: Weld Edges into Faces(MESH_OT_face_split_by_edges) (authored by Nick Milios (semaphore), committed by Dalai Felinto (dfelinto)). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
19 lines

Diff 10822

View Options

source/blender/editors/mesh/editmesh_intersect.c

Loading...