Aeden McClain (platypro) retitled this revision from Multi-Object-Editing: Make Planar Faces to Multi-Object-Editing: Make Planar Faces (MESH_OT_vert_connect_nonplanar).

Aeden McClain (platypro) added a reviewer: Dalai Felinto (dfelinto).

objects was not freed.
You shouldn't return when one call fails, you should continue the for loop.
For loop should be skipped (continue) when no selected vertices.

This revision now requires changes to proceed.May 11 2018, 12:23 PM

For loop continues when one operation fails
For loop stops immediately if no faces are selected
Object List is freed

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2018, 1:05 PM

Closed by commit rBb942106c738b: Multi-Object: MESH_OT_vert_connect_nonplanar by Aeden McClain (authored by Dalai Felinto (dfelinto)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Committed with changes, thanks for your contribution. Read further on our indentation settings:

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

mesh/

editmesh_tools.c

33 lines

Diff 10825

View Options

source/blender/editors/mesh/editmesh_tools.c

Multi-Object-Editing: Make Planar Faces (MESH_OT_vert_connect_nonplanar)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10825

source/blender/editors/mesh/editmesh_tools.c

Multi-Object-Editing: Make Planar Faces (MESH_OT_vert_connect_nonplanar)
ClosedPublic
Actions

Revision Contents
Changeset List