Page MenuHome
Differential D3318

Multi-Object-Mode: Edit MetaBall Tool select all (MBALL_OT_select_all)
AbandonedPublic
Actions

Authored by Nick Milios (semaphore) on May 10 2018, 5:19 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T54649: Multi-Object-Mode: Edit MetaBall Tools

Diff Detail

Repository
rB Blender

Event Timeline

Nick Milios (semaphore) created this revision.May 10 2018, 5:19 PM
Nick Milios (semaphore) added a task: T54649: Multi-Object-Mode: Edit MetaBall Tools.
Nick Milios (semaphore) abandoned this revision.May 12 2018, 11:53 PM
Nick Milios (semaphore) reclaimed this revision.May 13 2018, 3:25 PM
Nick Milios (semaphore) updated this revision to Diff 10890.May 13 2018, 3:28 PM

rebase into 2.8 head

Dalai Felinto (dfelinto) requested changes to this revision.May 14 2018, 2:36 PM
Dalai Felinto (dfelinto) added inline comments.
source/blender/editors/metaball/mball_edit.c
136

You can't return in the middle of the for loop, you should continue instead. Also please use BKE_mball_is_any_unselected

This revision now requires changes to proceed.May 14 2018, 2:36 PM
Nick Milios (semaphore) updated this revision to Diff 10940.May 15 2018, 3:07 PM
  • Fixed missed return statement and rebase 2.8
Nick Milios (semaphore) marked an inline comment as done.May 15 2018, 3:08 PM
Nick Milios (semaphore) updated this revision to Diff 10986.May 16 2018, 4:05 PM
  • check BKE_mball_is_any_unselected and BKE_mball_is_any_selected
Nick Milios (semaphore) updated this revision to Diff 10988.May 16 2018, 4:14 PM
  • Fix SEL_TOGGLE case not working
Dalai Felinto (dfelinto) requested changes to this revision.Nov 2 2018, 8:18 PM

See D3431 for comments.

This revision now requires changes to proceed.Nov 2 2018, 8:18 PM
Nick Milios (semaphore) abandoned this revision.Nov 5 2018, 10:18 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
metaball/
13 lines

Diff 10773

View Options

source/blender/editors/metaball/mball_edit.c

Loading...