Page MenuHome
Differential D3320

Multi-Object-Mode: Edit MetaBall Tool select similar (MBALL_OT_select_similar)
AbandonedPublic
Actions

Authored by Nick Milios (semaphore) on May 10 2018, 5:34 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T54649: Multi-Object-Mode: Edit MetaBall Tools

Diff Detail

Repository
rB Blender
Branch
arcpatch-D3320 (branched from blender2.8)
Build Status
Buildable 1592
Build 1592: arc lint + arc unit

Event Timeline

Nick Milios (semaphore) created this revision.May 10 2018, 5:34 PM
Nick Milios (semaphore) added a task: T54649: Multi-Object-Mode: Edit MetaBall Tools.
Nick Milios (semaphore) abandoned this revision.May 12 2018, 11:53 PM
Nick Milios (semaphore) updated this revision to Diff 10892.May 13 2018, 4:14 PM
In D3310#77652, @Dalai Felinto (dfelinto) wrote:

I think this operator should treat all the objects as one, not as separated ones in a for loop.
See for example the file:

select_similar.blend60 KBDownload

In this case if you Select Similar > Direction it should select all the edges of both objects. Not the "horizontal" ones in the yellow, and the "vertical" ones in the blue.

Nick Milios (semaphore) added a comment.May 13 2018, 4:19 PM

it can be done with better performance by joining into a list of selected MetaElem and then search into all MetaBall targets, but it become complicated and unmaintainable.

Nick Milios (semaphore) added a subscriber: Campbell Barton (campbellbarton).EditedMay 13 2018, 5:10 PM

i have never used MetaBall so i can not check if this is applied here and where:

In D3310#77661, @Campbell Barton (campbellbarton) wrote:

There is a mapping problem with this operator.

  • Scale of comparisons should be corrected for (so area/length/direction of face gives visually correct results - accounting for object scale).
Nick Milios (semaphore) updated this revision to Diff 10943.May 15 2018, 4:05 PM

rebase 2.8

Nick Milios (semaphore) updated this revision to Diff 10944.May 15 2018, 4:06 PM

rebase 2.8

Dalai Felinto (dfelinto) requested changes to this revision.Nov 2 2018, 8:23 PM
Dalai Felinto (dfelinto) added a subscriber: Habib Gahbiche (zazizizou).

There are other selected similar operators to refer to (pose, editmesh). We should use the same logic accross all of them. @Habib Gahbiche (zazizizou) maybe you are interested on tackling this after you are done with the curve operator?

This revision now requires changes to proceed.Nov 2 2018, 8:23 PM
Habib Gahbiche (zazizizou) added a comment.Nov 2 2018, 10:53 PM

@Habib Gahbiche (zazizizou) maybe you are interested on tackling this after you are done with the curve operator?

Sure, I'd be happy to.

Nick Milios (semaphore) abandoned this revision.Nov 5 2018, 10:19 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
metaball/
186 lines

Diff 10943

View Options

source/blender/editors/metaball/mball_edit.c

Loading...