Paths

Table of Contentst

Differential D3322

Multi-Object-Mode: Edit MetaBall Tool duplicate (MBALL_OT_duplicate_metaelems)
AbandonedPublic
Actions

Authored by Nick Milios (semaphore) on May 10 2018, 5:39 PM.

Tags

None

Subscribers

None

Details

Reviewers

Dalai Felinto (dfelinto)

Maniphest Tasks

T54649: Multi-Object-Mode: Edit MetaBall Tools

Diff Detail

Repository

Branch

arcpatch-D3322 (branched from blender2.8)

Build Status

Buildable 1596
Build 1596: arc lint + arc unit

Event Timeline

Nick Milios (semaphore) created this revision.May 10 2018, 5:39 PM

Nick Milios (semaphore) added a task: T54649: Multi-Object-Mode: Edit MetaBall Tools.

Nick Milios (semaphore) abandoned this revision.May 12 2018, 11:54 PM

Nick Milios (semaphore) updated this revision to Diff 10886.May 13 2018, 3:15 PM

rebase 2.8

rebase 2.8

Dalai Felinto (dfelinto) requested changes to this revision.May 16 2018, 2:31 PM

Dalai Felinto (dfelinto) added inline comments.

source/blender/editors/metaball/mball_edit.c
442	You should test for `BKE_mball_is_any_selected(mb) == false` instead. Not only I believe your test is wrong, but double negatives are really hard to follow.

This revision now requires changes to proceed.May 16 2018, 2:31 PM

Nick Milios (semaphore) added a comment.May 16 2018, 3:03 PM

This comment was removed by Nick Milios (semaphore).

source/blender/editors/metaball/mball_edit.c
442	I copied the code from rB847f028b715f20aea1021220e18da1183f45c131 in order to have unified code.

use BKE_mball_is_any_selected

Thanks, I couldn't rebase due to some conflict, but I re-implemented this as: rB046ec863ffc35e2daae105e4b5911076f1aade1d

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

metaball/

39 lines

Diff 10947

source/blender/editors/metaball/mball_edit.c

Loading...