Page MenuHome

Remesh modifier port to 2.8
AbandonedPublic

Authored by Christian Hubert (alikendarfen) on May 10 2018, 8:23 PM.

Details

Summary

Needed to assign totxxx in BKE_mesh_new_nomain (other equivalent functions not verified)

Diff Detail

Repository
rB Blender
Branch
mod_remesh_to2.8 (branched from blender2.8)
Build Status
Buildable 1544
Build 1544: arc lint + arc unit

Event Timeline

Sybren, following the modification in mesh.c that was needed here, I've checked all the file and found this 3 others which could be updated about totxxx value:

  • BKE_mesh_free
  • BKE_mesh_copy_data
  • BKE_mesh_copy

Maybe you'll want to keep all that in a separated update. So I won't propose one myself.

More explanation:

  • This revision is a port of remesh modifier
  • In this context, the algorithm use a octree lib which failed to run without a modifier to mesh.c
  • The cause of that is totvert, totedge, totface, etc. were not assigned to by BKE_mesh_new_nomain. So I had to modify it too

The totxxx assignment is well spotted, and I've committed just that change on your behalf in bcb245bd7137a8c3df061ed349c41c2247c6ef0f.

Sybren A. Stüvel (sybren) requested changes to this revision.May 11 2018, 3:42 PM

Also build with WITH_MOD_REMESH=OFF; that still uses DerivedMesh.

This revision now requires changes to proceed.May 11 2018, 3:42 PM

Corrected the code part where WITH_MOD_REMESH is off.