Page MenuHome
Differential D3338

Multi-Object Editing: MESH_OT_bridge_edge_loops
AbandonedPublic
Actions

Authored by Eoin O'Neill (eoinoneill.yokai) on May 11 2018, 12:53 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Summary

Contribution to T54643

Added multi-object editing support for bridge edge loops.

Diff Detail

Repository
rB Blender

Event Timeline

Eoin O'Neill (eoinoneill.yokai) created this revision.May 11 2018, 12:53 AM
Eoin O'Neill (eoinoneill.yokai) mentioned this in T54643: Multi-Object-Mode: EditMesh Tools.
Eoin O'Neill (eoinoneill.yokai) edited the summary of this revision. (Show Details)May 11 2018, 12:56 AM
Campbell Barton (campbellbarton) requested changes to this revision.May 11 2018, 8:34 AM

This is a more complicated operator which I don't think fits well to be put in a for loop.

Could you extract the loop body into it's own function?

This revision now requires changes to proceed.May 11 2018, 8:34 AM
Dalai Felinto (dfelinto) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 11 2018, 10:42 AM
Eoin O'Neill (eoinoneill.yokai) added a comment.May 11 2018, 8:02 PM

Yes, I'll try that when I get back today. Sorry for the delayed response!

Eoin O'Neill (eoinoneill.yokai) updated this revision to Diff 10843.EditedMay 12 2018, 1:38 AM

So I've isolated the body of the for loop into its own function (taking in an edit mesh and a wmOperator for any additional information). I decided to pass in the user-configurable values as arguments since those shouldn't change during the process of iterating through all the mesh assets. It may be ideal to break those options into a struct in order to make the function call more clean in the future (in case more arguments will need to be passed further down the line.)

I hope this is what you meant by breaking the body into its own function. For optimization sake, we may want to check and skip any object that doesn't have more than 2 faces (or two loops) selected, but I'm unsure of the cleanest way to do so. T54643

Dalai Felinto (dfelinto) mentioned this in D3261: Multi-Object-Mode: bridge edge loops tool (MESH_OT_bridge_edge_loops).May 14 2018, 3:31 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Sep 3 2018, 3:57 PM

Committed, thanks for the patch. However I made a mistake :/
I credited the wrong author in the commit (I had both this and D3261 patches open :/)

The commit is here anyways:
rBeb2226dde28421700da64dfc3716e82fa09905f2

I'll be more careful in the future. Meanwhile may I recommend you to use arc diff for your future contributions? Among other benefits it allows the final patch to be committed with you as the author even when you have no commit rights to Blender' s base code.

Dalai Felinto (dfelinto) abandoned this revision.Sep 4 2018, 4:33 PM
Eoin O'Neill (eoinoneill.yokai) added a comment.Oct 11 2018, 9:49 AM

@Dalai Felinto (dfelinto) No worries, and sorry I didn't respond right away. Yeah that's OK with me, I'm just glad to have helped contribute a bit to blender. :) I'll be back to supply whatever I can, so no worries.

That's interesting about arc diff, sorry I am used to using git diff instead so I just instinctively used that for this patch as well. I'll use that in future patches.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
191 lines

Diff 10797

View Options

source/blender/editors/mesh/editmesh_tools.c

Loading...