Paths

Table of Contentst

Differential D3339

Corrective smooth modifier port to 2.8
ClosedPublic
Actions

Authored by Christian Hubert (alikendarfen) on May 11 2018, 8:56 AM.

Tags

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)

Commits

rBS17ac0e824b99: Modifiers: ported Corrective Smooth DerivedMesh → Mesh
rB17ac0e824b99: Modifiers: ported Corrective Smooth DerivedMesh → Mesh

Diff Detail

Repository

Branch

mod_correctivesmooth_to2.8 (branched from blender2.8)

Build Status

Buildable 1536
Build 1536: arc lint + arc unit

Event Timeline

Christian Hubert (alikendarfen) created this revision.May 11 2018, 8:56 AM

Sybren A. Stüvel (sybren) added inline comments.May 11 2018, 11:17 AM

source/blender/modifiers/intern/MOD_correctivesmooth.c
128	Why the change in name here? With the other functions, you changed `dm_` to `mesh_`, but here you remove it instead.
716	You can just replace `derivedData` with `mesh`
719	Rename `mesh` to `mesh_src` to be consistent with the other modifiers.

Sybren A. Stüvel (sybren) accepted this revision.May 11 2018, 11:23 AM

This revision is now accepted and ready to land.May 11 2018, 11:23 AM

Renamed some variables + function

Harbormaster completed remote builds in B1539: Diff 10810.May 11 2018, 11:25 AM

Closed by commit rB17ac0e824b99: Modifiers: ported Corrective Smooth DerivedMesh → Mesh (authored by Christian Hubert (alikendarfen), committed by Sybren A. Stüvel (sybren)). · Explain WhyMay 11 2018, 11:27 AM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) mentioned this in T54737: Modifiers: Convert from DerivedMesh → Mesh.May 11 2018, 11:27 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

MOD_correctivesmooth.c

96 lines

Diff 10800

source/blender/modifiers/intern/MOD_correctivesmooth.c

Loading...