Paths

Table of Contentst

Differential D3340

Laplacian smooth modifier port to 2.8
ClosedPublic
Actions

Authored by Christian Hubert (alikendarfen) on May 11 2018, 9:28 AM.

Tags

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)

Commits

rBS68b736ce248f: Modifiers: ported Laplacian Smooth DerivedMesh → Mesh
rB68b736ce248f: Modifiers: ported Laplacian Smooth DerivedMesh → Mesh

Diff Detail

Repository

Branch

mod_laplaciansmooth_to2.8 (branched from blender2.8)

Build Status

Buildable 1537
Build 1537: arc lint + arc unit

Event Timeline

Christian Hubert (alikendarfen) created this revision.May 11 2018, 9:28 AM

Sybren A. Stüvel (sybren) requested changes to this revision.May 11 2018, 3:36 PM

Sybren A. Stüvel (sybren) added inline comments.

source/blender/modifiers/intern/MOD_laplaciansmooth.c
45	Keep new includes ordered alphabetically.
504	Rename `mesh` to `mesh_src` and `meshData` to `mesh`, to be consistent with other modifiers.
522	Rename `mesh` to `mesh_src` and `meshData` to `mesh`, to be consistent with other modifiers.

This revision now requires changes to proceed.May 11 2018, 3:36 PM

Changes:

Added includes in alphabetical order
Convention for naming mesh mesh_src in deformVerts and deformVertsEM

This revision was not accepted when it landed; it landed in state Needs Review.May 11 2018, 4:53 PM

Closed by commit rB68b736ce248f: Modifiers: ported Laplacian Smooth DerivedMesh → Mesh (authored by Christian Hubert (alikendarfen), committed by Sybren A. Stüvel (sybren)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) mentioned this in T54737: Modifiers: Convert from DerivedMesh → Mesh.May 11 2018, 4:54 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

MOD_laplaciansmooth.c

49 lines

Diff 10801

source/blender/modifiers/intern/MOD_laplaciansmooth.c

Loading...