Multi object edit: Added MESH_OT_vert_connect_path
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on May 12 2018, 1:05 AM.

Details

Reviewers

Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)

Maniphest Tasks

T54643: Multi-Object-Mode: EditMesh Tools

Commits

rBSfc7316fb544d: Multi-Objects: MESH_OT_vert_connect_path by Falk David
rBfc7316fb544d: Multi-Objects: MESH_OT_vert_connect_path by Falk David

Summary

Rebased and cleaned the old diff.

Diff Detail

Repository

rB Blender

Branch

multi_object_editing_vert_connect_path (branched from blender2.8)

Build Status

Buildable 1552
Build 1552: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) created this revision.May 12 2018, 1:05 AM

Falk David (filedescriptor) retitled this revision from Rebased and cleanup to Multi object edit: Added MESH_OT_vert_connect_path.May 12 2018, 1:07 AM

Falk David (filedescriptor) added a project: BF Blender: 2.8.

Falk David (filedescriptor) edited the summary of this revision. (Show Details)May 12 2018, 1:11 AM

See in-line suggestions.

By the way, if you don't mind exposing your email address and you setup your git to use your real full name I can commit your patches preserving your name/email in the final commit.

source/blender/editors/mesh/editmesh_tools.c
1097	Make it a bool and return true/false. Otherwise your `if (!bm_connect_vert_pair(em, op)) {` calls will all fail since OPERATOR_CANCELLED is not 0.
1465	You shouldn't report an error for every object of the loop. It should be reported only if they all fail for the same reason.