Page MenuHome
Differential D3351

Multi-Object-Editing: MESH_OT_shortest_path_select
ClosedPublic
Actions

Authored by Ish Bosamiya (ish_bosamiya) on May 12 2018, 12:33 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Commits
rBS5a431be62994: Multi-Object-Editing: MESH_OT_shortest_path_select
rB5a431be62994: Multi-Object-Editing: MESH_OT_shortest_path_select
Summary

Support for shortest path select in multi object edit

Contribution to T54643

Diff Detail

Event Timeline

Ish Bosamiya (ish_bosamiya) created this revision.May 12 2018, 12:33 PM
Ish Bosamiya (ish_bosamiya) mentioned this in T54643: Multi-Object-Mode: EditMesh Tools.May 12 2018, 12:39 PM
Ish Bosamiya (ish_bosamiya) edited the summary of this revision. (Show Details)May 13 2018, 7:59 AM
Ish Bosamiya (ish_bosamiya) added a task: T54643: Multi-Object-Mode: EditMesh Tools.May 14 2018, 6:46 AM
Dalai Felinto (dfelinto) requested changes to this revision.May 14 2018, 2:14 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Thanks for your contribution, but the patch needs changes to proceed. Aside from the in-line comments:
Need to skip the for loop when no relevant element is selected (in this case I believe you want to test against vert, edge and faces).

source/blender/editors/mesh/editmesh_path.c
737

Move the { to the previous line with a space between the ) and the {. We only use the bracket in a new line when there is a multi-line if/for.

796

BKE_report shouldn't be called for every object in the loop. It should be called only once and only if all the objects fail with the same error.

This revision now requires changes to proceed.May 14 2018, 2:14 PM
Ish Bosamiya (ish_bosamiya) updated this revision to Diff 10915.May 14 2018, 3:29 PM

I have made the changes asked for.

The for loop is now skipped when there is no element selected.
BKE_report() is now called as a collective for all the objects after the loop.
The for loop bracket has been fixed.

Dalai Felinto (dfelinto) requested changes to this revision.May 14 2018, 3:51 PM

Thanks but you need to always send the full patch, not an incremental one.

In fact it is much better if you can use arc:

To update the patch instead of creating a new one make sure the patch is updated with 2.8 and arc diff --update D3351

This revision now requires changes to proceed.May 14 2018, 3:51 PM
Ish Bosamiya (ish_bosamiya) updated this revision to Diff 10930.May 14 2018, 9:25 PM
  • QT Creator Project Files
  • Multi-Object-Editing: MESH_OT_shortest_path_select
  • BKE_report() is now called only if all objects fail
Ish Bosamiya (ish_bosamiya) added a comment.May 14 2018, 9:31 PM

I tried to use arc. I have setup everything for arc to work. I have also executed the command "arc diff --update D3351". I had some qt creator files that were uploaded in the arc diff as well. How should I remove this and prevent it from happening in the future difference uploads?

Dalai Felinto (dfelinto) requested changes to this revision.May 16 2018, 1:01 PM

As for removing the other files you need to do git rm FILENAME. Go on irc on #blendercoders if you need extra help.

source/blender/editors/mesh/editmesh_path.c
802

No point in adding a continue in the end of the for block.

808

Add a space between if and (:

This revision now requires changes to proceed.May 16 2018, 1:01 PM
Ish Bosamiya (ish_bosamiya) updated this revision to Diff 10978.May 16 2018, 2:48 PM

Refactored code as asked

  • Multi-Object-Editing: MESH_OT_shortest_path_select
  • BKE_report() is now called only if all objects fail
  • Ignoring qt creator files
  • Revert "Ignoring qt creator files"
  • Code Refactoring
This revision was not accepted when it landed; it landed in state Needs Review.May 24 2018, 7:34 PM
Closed by commit rB5a431be62994: Multi-Object-Editing: MESH_OT_shortest_path_select (authored by Ish Bosamiya (ish_bosamiya), committed by Dalai Felinto (dfelinto)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a comment.May 24 2018, 7:34 PM

Commit with minor changes: 5a431be629940e0ecffba047e80e0946a01f3aa4
Thanks for your contribution.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
25 lines

Diff 10915

View Options

source/blender/editors/mesh/editmesh_path.c

Loading...