Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- MO_smooth_laplacian_vertex (branched from blender2.8)
- Build Status
Buildable 1564 Build 1564: arc lint + arc unit
Event Timeline
Comment Actions
I'm a bit unsure how to handle failure cases on this. I could for example do a separate pass to check if there is any n-gons first and then let that fail. But I don't want it to be intrusive on the workflow.
Comment Actions
You could use a uint to count the object that fails, see an example: D3243
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 2190 | all RNA_*_get/set calls should be outside of for loop | |
| 2215 | all BKE_report should be outside of the loop and thrown only if the same fault occurs for all objecs with selected verticies. | |
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 2190 | From what I see they are all outside the loop. Am I missing something here? | |
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 2190 | Sorry, my mistake | |