Page MenuHome
Differential D3367

Multi-Object-Mode: EditMesh Tool loop select (MESH_OT_loop_select)
AbandonedPublic
Actions

Authored by Nick Milios (semaphore) on May 13 2018, 8:56 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools

Diff Detail

Event Timeline

Nick Milios (semaphore) created this revision.May 13 2018, 8:56 PM
Nick Milios (semaphore) added reviewers: Dalai Felinto (dfelinto), Campbell Barton (campbellbarton).
Nick Milios (semaphore) added projects: BF Blender: 2.8, Code Quest.
Nick Milios (semaphore) added a task: T54643: Multi-Object-Mode: EditMesh Tools.
Nick Milios (semaphore) planned changes to this revision.EditedMay 13 2018, 9:08 PM

i will do some cleanup tomorrow after my job...

  • ViewLayer *view_layer not needed
  • it may be code that can be placed outside of the loop
Nick Milios (semaphore) updated this revision to Diff 10954.May 15 2018, 4:43 PM
  • Cleanup
  • rebese 2.8
Dalai Felinto (dfelinto) requested changes to this revision.May 16 2018, 12:57 PM

A few problems with this:

  • I can select an edge loop in two different meshes at the same time.
  • Edge loop selecting without shift is leaving the edge loop in all other objects still selected (where they shouldn't).

You should try using unified_findnearest instead.

This revision now requires changes to proceed.May 16 2018, 12:57 PM
Nick Milios (semaphore) updated this revision to Diff 10979.May 16 2018, 2:49 PM
  • without unified_findnearest failure
  • - use unified_findnearest instead of EDBM_edge_find_nearest_ex
Nick Milios (semaphore) updated this revision to Diff 10980.May 16 2018, 2:54 PM
  • restore unneeded modification of code
Dalai Felinto (dfelinto) abandoned this revision.Sep 4 2018, 4:58 PM

Operator already committed as:

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
10 lines

Diff 10895

View Options

source/blender/editors/mesh/editmesh_select.c

Loading...