Page MenuHome
Differential D3372

Multi-Object-Editing: MESH_OT_faces_select_linked_flat
ClosedPublic
Actions

Authored by Luc Revardel (lrevardel) on May 14 2018, 12:35 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Commits
rBS1bb9ccf88756: Multi-Object-Editing: MESH_OT_faces_select_linked_flat
rB1bb9ccf88756: Multi-Object-Editing: MESH_OT_faces_select_linked_flat

Diff Detail

Event Timeline

Luc Revardel (lrevardel) created this revision.May 14 2018, 12:35 PM
Luc Revardel (lrevardel) retitled this revision from Multi-Object-Editing: MESH_OT_faces_select_linked_flat Proposal for participation to T54643. to Multi-Object-Editing: MESH_OT_faces_select_linked_flatProposal for participation to T54643..May 14 2018, 12:40 PM
Luc Revardel (lrevardel) added a task: T54643: Multi-Object-Mode: EditMesh Tools.
Dalai Felinto (dfelinto) requested changes to this revision.May 14 2018, 2:18 PM

Thanks for your contribution, patch needs changes to proceed though.
See in-line comments.

source/blender/editors/mesh/editmesh_select.c
3858

Move all RNA_.*_get outside the for loop. This in particular is calculating cos for every object with no need.

This revision now requires changes to proceed.May 14 2018, 2:18 PM
Luc Revardel (lrevardel) updated this revision to Diff 10932.May 15 2018, 8:06 AM

Updated according to Dalai's code review comments.

Harbormaster completed remote builds in B1582: Diff 10932.May 15 2018, 8:06 AM
Luc Revardel (lrevardel) marked an inline comment as done.May 15 2018, 12:03 PM
Dalai Felinto (dfelinto) retitled this revision from Multi-Object-Editing: MESH_OT_faces_select_linked_flatProposal for participation to T54643. to Multi-Object-Editing: MESH_OT_faces_select_linked_flat.May 16 2018, 1:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 16 2018, 1:05 PM
Closed by commit rB1bb9ccf88756: Multi-Object-Editing: MESH_OT_faces_select_linked_flat (authored by Luc Revardel (lrevardel), committed by Dalai Felinto (dfelinto)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a comment.May 16 2018, 1:06 PM

Thank you, committed.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
85 lines

Diff 10907

View Options

source/blender/editors/mesh/editmesh_select.c

Loading...