Page MenuHome
Differential D3390

Multi object edit - UV_OT_pin
AbandonedPublic
Actions

Authored by Alan Troth (Al) on May 16 2018, 5:35 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Dalai Felinto (dfelinto)
Maniphest Tasks
T54645: Multi-Object-Mode: EditMesh UV Tools
Summary

Multi object edit - UV_OT_pin

Diff Detail

Repository
rB Blender

Event Timeline

Alan Troth (Al) created this revision.May 16 2018, 5:35 PM
Alan Troth (Al) added a task: T54645: Multi-Object-Mode: EditMesh UV Tools.
Alan Troth (Al) updated this revision to Diff 10995.May 16 2018, 11:17 PM

Replaced

BKE_view_layer_array_from_objects_in_edit_mode_unique_data(

with

BKE_view_layer_array_from_objects_in_edit_mode_unique_data_with_uvs(

.

Nick Milios (semaphore) added a subscriber: Nick Milios (semaphore).May 17 2018, 12:45 AM

Also I sugest you to use Arcanist for your diffs it will be esasier for you to do changes:
https://wiki.blender.org/index.php/Dev:Doc/Tools/Code_Review#Use_Arcanist

source/blender/editors/uvedit/uvedit_ops.c
3672

MEM_freeN(objects);

3672

MEM_freeN(objects);

Alan Troth (Al) updated this revision to Diff 11020.May 17 2018, 11:55 PM

Added the freeing of '**objects'.

Campbell Barton (campbellbarton) added inline comments.May 18 2018, 2:00 PM
source/blender/editors/uvedit/uvedit_ops.c
3670

Should only add notifier if a change is made.

Campbell Barton (campbellbarton) requested changes to this revision.May 18 2018, 2:01 PM
This revision now requires changes to proceed.May 18 2018, 2:01 PM
Alan Troth (Al) updated this revision to Diff 11025.May 19 2018, 1:11 AM

Added code so WM_event_add_notifier(..) is only called for an object when the pinned status of any of its uvs changes.

Alan Troth (Al) marked 3 inline comments as done.May 19 2018, 1:18 AM
Dalai Felinto (dfelinto) abandoned this revision.Sep 4 2018, 4:11 PM

Thanks for the patch.
I committed a different version on rB0f50caf5560f9c2f9af393eefdf2b209210dbfba.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
uvedit/
44 lines

Diff 10995

View Options

source/blender/editors/uvedit/uvedit_ops.c

Loading...