Details
- Reviewers
Campbell Barton (campbellbarton) Dalai Felinto (dfelinto) - Maniphest Tasks
- T54643: Multi-Object-Mode: EditMesh Tools
Diff Detail
- Repository
- rB Blender
- Branch
- blender2.8
- Build Status
Buildable 1646 Build 1646: arc lint + arc unit
Event Timeline
I'm new to the Code Quest, and I've tried to make sure this is aligned to how you all do things.
I have read the docs, but if I missed something, please let me know and I'll fix it moving forward. Glad to help!
Hi @Evan (evanvlane), welcome to Code Quest
Thank you for your help!
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 2268 |
| |
| 2281 |
| |
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 2258 | i thing totvertsel should be totfacesel | |
Edit mesh: multi-object vertex smooth support.
Update: Incorporated changes suggested by semaphore.
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 2268 |
I implemented this with a blocking flag to avoid smoothing anything if one n-gon is selected on any of the objects. | |
| source/blender/editors/mesh/editmesh_tools.c | ||
|---|---|---|
| 2293 | You should check for vert, edge and face, not only faces | |
| 2301 | You want to break, not continue. | |
| 2304–2305 | use { for if statements: | |
| 2314 | This is tricky. You probably want to break from the for repeat loop, and continue the for (uint ob_index = 0; ob_index < objects_len; ob_index++) { loop. You only want to update the editmesh if all the repeat loop succeeded. | |