Differential D3414

COW Operators: Fix VIEW3D_OT_snap_cursor_to _active _selected _center and _grid
ClosedPublic
Actions

Authored by Inês Almeida (brita_) on May 20 2018, 9:38 AM.

Tags

None

Subscribers

None

Details

Reviewers

Sergey Sharybin (sergey)
Joshua Leung (aligorith)

Maniphest Tasks

T54829: COW Operators: 3D View

Commits

rBSe12df10120a0: COW Operators: Fix VIEW3D_OT_snap_cursor_to _active _selected _center and _grid
rBe12df10120a0: COW Operators: Fix VIEW3D_OT_snap_cursor_to _active _selected _center and _grid

Diff Detail

Repository

Branch

cow-ops-view4 (branched from blender2.8)

Build Status

Buildable 1659
Build 1659: arc lint + arc unit

Event Timeline

Inês Almeida (brita_) created this revision.May 20 2018, 9:38 AM

Inês Almeida (brita_) added a task: T54829: COW Operators: 3D View.May 20 2018, 9:40 AM

Inês Almeida (brita_) added inline comments.May 20 2018, 9:45 AM

source/blender/editors/space_view3d/view3d_snap.c
623	@Joshua Leung (aligorith) this is not working correctly! (snap to selected in pose mode) can you help me check why? snap to active is working well. These 2 are giving different pointers!? Object obact_eval = OBACT(view_layer_eval); Object obact_eval2 = DEG_get_evaluated_object(depsgraph, CTX_data_active_object(C));
649	no idea what this is. tracking related? then it can be checked later, because it is not high priority to have Spring starting to use 2.8

Inês Almeida (brita_) mentioned this in T54829: COW Operators: 3D View.May 20 2018, 9:47 AM

File I used for testing:

cow_tests_armature_animated.blend345 KBDownload

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2018, 12:24 PM

Closed by commit rBe12df10120a0: COW Operators: Fix VIEW3D_OT_snap_cursor_to _active _selected _center and _grid (authored by Inês Almeida (brita_)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Tuomo Keskitalo (tkeskita) mentioned this in D3413: T54829: Make VIEW3D_OT_snap_cursor_to_center to be aware of copy-on-write.May 22 2018, 6:20 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_view3d/

55 lines

Diff 11052

source/blender/editors/space_view3d/view3d_snap.c

Loading...