Details
- Reviewers
Dalai Felinto (dfelinto) Campbell Barton (campbellbarton) - Maniphest Tasks
- T54643: Multi-Object-Mode: EditMesh Tools
Diff Detail
- Repository
- rB Blender
- Branch
- blender2.8
- Build Status
Buildable 1680 Build 1680: arc lint + arc unit
Event Timeline
Saw it now, this operator is already under review(D3376). I did it some time ago and got stuck and had no time to continue. but his diff in contrary to 3376 has support for posemode (in theory when it would not crash)
It works for Meshes, but crashes for all other object types. I tested VIEW3D_OT_snap_selected_to_grid before Code Review with armatures and it worked. Now VIEW3D_OT_snap_selected_to_grid and VIEW3D_OT_snap_selected_to_cursor both crash with Segmentation fault on "non mesh objects" in Edit Mode. So it seems it it caused by some other change.
I tried to set up single step debugging with qt but it did not work. How do I set it up?
rebase and update
- Merge branch 'blender2.8' into arcpatch-D3425
- Removed Face/Vert/Edge-count check, since it causes crash on non-mesh-objects
- Moved CTX_DATA loop to the right place
Hi Leon,
I don't think this is the way the operator should behave. Try this:
Compare this
- Add and select two cubes in object mode
- perform snap_selection_to_cursor (use offset)
With this:
- Add and select two cubes in edit mode
- perform snap_selection_to_cursor (use offset)
The result with your patch is not the same. See D3648 for my proposed solution based on your code.
Best,
Habib.