Fix Asan for clang on windows
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on May 30 2018, 6:41 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Commits

rBS7c75c2db4f97: Add Asan support for clang on windows.
rB7c75c2db4f97: Add Asan support for clang on windows.

Summary

This makes asan work for the "RelWithDebInfo" configuration.

Ideally i'd like to add a configuration 'debug_asan' on windows, which will be identical to RelWithDebInfo but with the optimizer disabled. asan currently doesn't work with the debug-crt and i can't switch the debug config to use the release crt cause none of the libs will link against that.

Diff Detail

Repository: rB Blender

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.May 30 2018, 6:41 PM

Ray Molenkamp (LazyDodo) edited the summary of this revision. (Show Details)May 30 2018, 6:44 PM

One typo, otherwise LGTM.

CMakeLists.txt
551	Should be `${_asan_defaults}`

This revision is now accepted and ready to land.May 30 2018, 7:44 PM

You had a rather strong opinion last time i tried adding a configuration, any objections here ? (again, will only add it when windows+clang are in play)