Page MenuHome
Differential D3452

Fix T55140: opened image doesn't show up in movie clip editor
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jun 1 2018, 12:08 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rBS7ac0272b776a: Fix T55140: opened image doesn't show up in movie clip editor
rB7ac0272b776a: Fix T55140: opened image doesn't show up in movie clip editor
Summary

atoi usage in BLI_stringdec could overflow, use strtol instead and check
valid range with INT_MIN and INT_MAX

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jun 1 2018, 12:08 PM
Philipp Oeser (lichtwerk) mentioned this in T55140: opened image doesn't show up in movie clip editor.
Campbell Barton (campbellbarton) accepted this revision.Jun 8 2018, 9:06 AM

long is the same size as int on some systems, better use strtoll. Otherwise LGTM.

This revision is now accepted and ready to land.Jun 8 2018, 9:06 AM
Closed by commit rB7ac0272b776a: Fix T55140: opened image doesn't show up in movie clip editor (authored by Philipp Oeser (lichtwerk)). · Explain WhyJun 11 2018, 10:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenlib/
intern/
36 lines

Diff 11174

View Options

source/blender/blenlib/intern/path_util.c

Loading...