Page MenuHome
Differential D3472

Fix Minor Typo
ClosedPublic
Actions

Authored by John (personalcomputer) on Jun 12 2018, 8:26 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Lukas Stockner (lukasstockner97)
Commits
rC1024e11117f7: Fix T55448: Typo in Cycles CUDA debug output
rBS7bf40236893c: Fix T55448: Typo in Cycles CUDA debug output
rB7bf40236893c: Fix T55448: Typo in Cycles CUDA debug output
Summary

See https://developer.blender.org/T55448 for details on the typo.

This is a really small issue, but fixing it is an opportunity for me to learn Blender's build process + contribution process + phabricator so I am able to make more substantial bugfixes in the future.

Diff Detail

Repository
rB Blender

Event Timeline

John (personalcomputer) created this revision.Jun 12 2018, 8:26 AM
John (personalcomputer) edited the summary of this revision. (Show Details)Jun 12 2018, 8:35 AM
John (personalcomputer) edited the summary of this revision. (Show Details)Jun 12 2018, 8:44 AM
John (personalcomputer) edited the summary of this revision. (Show Details)
Lukas Stockner (lukasstockner97) accepted this revision.Jun 12 2018, 10:36 AM
Lukas Stockner (lukasstockner97) added a subscriber: Lukas Stockner (lukasstockner97).

Thanks for the patch! I'll go ahead and commit it.

Two suggestions for future patches:

  • Using the Arcanist tool makes it easier to submit and check out patches.
  • Your patch seems to be against a file in which the tab whitespace was replaced with spaces. This makes applying the patch tricky and probably introduces unwanted whitespace changes into the patch. I guess your editor is configured to automatically change whitespace, please disable that.
This revision is now accepted and ready to land.Jun 12 2018, 10:36 AM
Closed by commit rB7bf40236893c: Fix T55448: Typo in Cycles CUDA debug output (authored by Lukas Stockner (lukasstockner97)). · Explain WhyJun 12 2018, 10:46 AM
This revision was automatically updated to reflect the committed changes.
John (personalcomputer) added a comment.EditedJun 13 2018, 7:06 AM

Lukas thank you so much for taking the time to review this and provide me with that feedback!

  • I apologize for the tabs+spaces issue. I do note now that my diff represented it as spaces, which is a mistake, the file should be using tabs still. I will disable that conversion to ensure that any spaces/tabs are not accidentally changed again.
  • Thank you for showing me Arcanist, I will check it out for my future patches.

Thanks!

Revision Contents
Changeset List

PathSize
intern/
cycles/
device/
2 lines

Diff 11232

View Options

intern/cycles/device/device_cuda.cpp

Loading...