Image: Refactor render slots to a dynamic list
ClosedPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on Jun 12 2018, 2:36 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rBS525be2f579c9: Image: Refactor render slots to a dynamic list
rB525be2f579c9: Image: Refactor render slots to a dynamic list

Summary

Previously, render slots were hardcoded to a fixed amount.

With this change, render slots now are stored in a list. Therefore, users can add and/or remove as many slots as they want.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D3474_1 (branched from blender2.8)

Build Status

Buildable 1753
Build 1753: arc lint + arc unit

Event Timeline

Lukas Stockner (lukasstockner97) created this revision.Jun 12 2018, 2:36 PM

Harbormaster completed remote builds in B1751: Diff 11234.Jun 12 2018, 2:36 PM

Add Render Slots panel with list widget and +/-/x icons.
Only create render slots for render result images.
Always initialize slot names.

Updated with some UI tweaks.

One bug I found is that clear a slot while it is being render to crashes.

Otherwise this looks good to commit.

This revision now requires changes to proceed.Jun 14 2018, 5:49 PM

Lucas Boutrot (thornydre) added a subscriber: Lucas Boutrot (thornydre).Jun 14 2018, 6:04 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Jun 14 2018, 10:56 PM

Closed by commit rB525be2f579c9: Image: Refactor render slots to a dynamic list (authored by Lukas Stockner (lukasstockner97)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Duarte Farrajota Ramos (duarteframos) awarded a token.Jun 14 2018, 11:48 PM

This is a fantastic improvement, great work.
It would also be useful if Blender could automatically "auto advance" to the next slot upon rendering.

I can't envision a situation where you'd intentionally want to overwrite an existing slot, but one often wants to compare sequential images and forgets to change slots before, unintentionally overwriting the previous one.

In D3474#80418, @Duarte Farrajota Ramos (duarteframos) wrote:

This is a fantastic improvement, great work.
It would also be useful if Blender could automatically "auto advance" to the next slot upon rendering.

I can't envision a situation where you'd intentionally want to overwrite an existing slot, but one often wants to compare sequential images and forgets to change slots before, unintentionally overwriting the previous one.

Definitely!

In D3474#80418, @Duarte Farrajota Ramos (duarteframos) wrote:

It would also be useful if Blender could automatically "auto advance" to the next slot upon rendering.

I can't envision a situation where you'd intentionally want to overwrite an existing slot, but one often wants to compare sequential images and forgets to change slots before, unintentionally overwriting the previous one.

There's a proposal for that kind of thing here:
https://devtalk.blender.org/t/new-slots-system-in-render-view/731/13