Page MenuHome

[VSE] New effect - Shift
Needs ReviewPublic

Authored by Alexis Lozano (alexis_lozano) on Jun 13 2018, 12:27 PM.

Details

Summary

This add a new effect to VSE. The main goal is to shift the image (X and Y) and move the hidden part to the other side of the image. See the screenshot for a better understanding of what it does.

Diff Detail

Repository
rB Blender

Event Timeline

Changed the hue of the strip color to 0.50 in order to keep a 0.04 interval between every strips

Campbell Barton (campbellbarton) requested changes to this revision.Jun 15 2018, 3:31 PM
Campbell Barton (campbellbarton) added inline comments.
source/blender/makesdna/DNA_sequence_types.h
262

Suggest to remove this and use float. 1.0 is a full wrap in either direction.

553–556

Bump this and keep it last.

source/blender/makesrna/intern/rna_sequencer.c
2366–2371

Would rather not have this at all.

2379–2387

Can be a single property (2d vector).

This revision now requires changes to proceed.Jun 15 2018, 3:31 PM
source/blender/makesdna/DNA_sequence_types.h
262

This means 0.5 would wrap half the number of pixels.

I changed SEQ_TYPE_MAX to the highest value (72) and removed shift_unit variable (now between 0.0 and 1.0). However, I have not converted shift_x and shift_y to a 2d vector for two reasons : (1) the other effects have x and y separated variables - (2) I am not sure that I can then link this vector to the sliders in python.

Why not make this an option of the transform effect? This can also support rotation?

Why not make this an option of the transform effect? This can also support rotation?

This is not a true transformation.
May be an option though.
Personally I would rather keep this to separate.

When I have had need for a wrap effect in an NLE I've often thought that the option for mirroring would be useful so that you could loop a seamless texture in a scroll. The strip properties already support this as an image function Flip X and Y, is it possible to apply the flip function to the mirrored wrap?

When I have had need for a wrap effect in an NLE I've often thought that the option for mirroring would be useful so that you could loop a seamless texture in a scroll. The strip properties already support this as an image function Flip X and Y, is it possible to apply the flip function to the mirrored wrap?

basically you want: flip X -> shift -> flip Y

Not with this patch

But I want to have "atomized" effects / nodes, where you can do this
Will do some roadmap, so we can see what is to be done / discuss priority.