Move call to drw_state_ensure_not_reused() inside the region locked by DST.gl_context_mutex.
ClosedPublic
Actions

Authored by Edmund Kapusniak (edmundmk) on Jun 13 2018, 11:24 PM.

Details

Reviewers

Clément Foucault (fclem)
Brecht Van Lommel (brecht)

Commits

rBSd64cd6f7ee63: Move call to drw_state_ensure_not_reused() inside the region locked by DST.
rBd64cd6f7ee63: Move call to drw_state_ensure_not_reused() inside the region locked by DST.

Summary

Currently with a debug build there is a race condition where the mutex is released before the DST structure is reset to 0xFF, meaning when multiple threads are using the DRWManager it can get cleared when the main thread is using it, causing crashes.

Diff Detail

Repository: rB Blender

Event Timeline

Edmund Kapusniak (edmundmk) created this revision.Jun 13 2018, 11:24 PM

Edmund Kapusniak (edmundmk) retitled this revision from Move call to drw_state_ensure_not_reused() inside the region locked by DST.gl_lock_mutex. to Move call to drw_state_ensure_not_reused() inside the region locked by DST.gl_context_mutex..

Ray Molenkamp (LazyDodo) added reviewers: Clément Foucault (fclem), Brecht Van Lommel (brecht).Jun 14 2018, 3:41 AM

Clément Foucault (fclem) accepted this revision.Jun 14 2018, 10:01 AM

This revision is now accepted and ready to land.Jun 14 2018, 10:01 AM

Closed by commit rBd64cd6f7ee63: Move call to drw_state_ensure_not_reused() inside the region locked by DST. (authored by Clément Foucault (fclem)). · Explain WhyJun 14 2018, 12:03 PM

This revision was automatically updated to reflect the committed changes.