Page MenuHome
Differential D3492

Image : Frame Buffer > Slot system update and slot comparisons
Needs ReviewPublic
Actions

Authored by Lucas Boutrot (thornydre) on Jun 20 2018, 12:34 AM.
Tags
Subscribers
Duarte Farrajota Ramos (duarteframos)
Jason Clarke (jtheninja)
Marcel Quintas (MarcelQ)
Paul Larson (GeorgiaPacific)
xan2622 (xan2622)
Tokens
"Like" token, awarded by GeorgiaPacific."Love" token, awarded by xan2622."Love" token, awarded by Alumx."Yellow Medal" token, awarded by szap."Like" token, awarded by Samirosman."Love" token, awarded by duarteframos."Love" token, awarded by erickblender."Like" token, awarded by Ko.

Details

Reviewers
Brecht Van Lommel (brecht)
Summary

First bit of this proposal : https://devtalk.blender.org/t/new-slots-system-in-render-view/731/14

At the moment I set up the buttons so it made me play a bit with the code, now I am working on having a functional "Push" button.

  • UI buttons
  • Offset all the slots with the Push button
  • Make Auto Push after render work
  • Change slot attribute when toggle "Compare With"
  • Implement the different comparison modes
  • Add icons in the slots lists
  • Add preview thumbnails to the slots list

Known issues:

  • Toggle "Compare With" should have a default value of 1 and it shouldn't reset when we close the Image Editor
  • Version patching existing files
  • Crash sometimes when trying to display a slot

Not related bugs:

  • Actually it crashes when Reload Start-Up file and the image editor is open

Diff Detail

Repository
rB Blender

Event Timeline

Lucas Boutrot (thornydre) created this revision.Jun 20 2018, 12:34 AM
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)Jun 21 2018, 11:33 AM
Lucas Boutrot (thornydre) added a project: BF Blender: 2.8.
Lucas Boutrot (thornydre) updated this revision to Diff 11302.Jun 24 2018, 12:50 PM

First step to get the Push button working

Konstantin (Ko) awarded a token.Jun 24 2018, 1:04 PM
Erick Tukuniata (erickblender) awarded a token.Jun 24 2018, 2:16 PM
Lucas Boutrot (thornydre) updated this revision to Diff 11317.Jun 27 2018, 10:53 PM
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)

I have the Push Button working for the slots, but at the moment to "copy" the first slot into the second one, I use RE_SwapResult, because using slot->render = &rres; does not work, is there another function I can use for this ?

Lucas Boutrot (thornydre) updated this revision to Diff 11318.Jun 28 2018, 12:36 AM
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)

I found a solution, so the frame buffer is now working ! :)

Lucas Boutrot (thornydre) updated this revision to Diff 11320.Jun 28 2018, 12:51 AM
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)

Auto push working

Duarte Farrajota Ramos (duarteframos) awarded a token.Jun 28 2018, 1:26 AM
Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)Jun 28 2018, 1:07 PM
Lucas Boutrot (thornydre) updated this revision to Diff 11331.Jun 29 2018, 9:04 PM

First step to handle the "Compare With" toggle

Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)Jun 30 2018, 10:49 AM
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)Jun 30 2018, 1:56 PM
Brecht Van Lommel (brecht) added inline comments.Jul 2 2018, 6:21 PM
source/blender/render/intern/source/pipeline.c
354

It's work in progress code, but just so you're aware, this is not correct. To copy the render result its contents would need to be copied too.

It's probably best to use RE_SwapResult instead though, to move the render result from the renderer to the render slot. This only works when the render is done, but I think that's ok.

Lucas Boutrot (thornydre) updated this revision to Diff 11341.Jul 3 2018, 9:56 PM
Lucas Boutrot (thornydre) marked an inline comment as done.
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)

Use RE_SwapResult again, and now J key is used to compare between the compared slot and the current render result (looking for comparing with last displayed slot instead)

Jason Clarke (jtheninja) added a subscriber: Jason Clarke (jtheninja).Jul 5 2018, 10:46 PM
Lucas Boutrot (thornydre) updated this revision to Diff 11387.Jul 11 2018, 10:52 PM

Move compare_slot from SpaceImage to Image so that it does not reset when Image Editor is closed.

Have to find a way to access SpaceImage from rna_image.c rna_render_slots_active_index_set to handle the toggle when we click on the list in the N panel instead of the heade's list. Maybe I should move compare_with to Image too ?

Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)Jul 11 2018, 10:56 PM
Samir Osman (Samirosman) awarded a token.Jul 12 2018, 1:33 PM
Lucas Boutrot (thornydre) updated this revision to Diff 11399.Jul 12 2018, 9:40 PM

Make compare_slot = 1 by default again (needed to change since it is part of Image now and not SpaceImage) and clear Render slot when it is pushed.

I would like to start working on manipulator for the slider, and on image drawing to test the difference comparison mode now.

Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)Jul 12 2018, 9:40 PM
Lucas Boutrot (thornydre) edited the summary of this revision. (Show Details)Jul 13 2018, 12:49 AM
paul szajner (szap) awarded a token.Sep 17 2018, 2:18 PM
Marcel Quintas (MarcelQ) added a subscriber: Marcel Quintas (MarcelQ).May 12 2020, 7:48 PM
Vas (Alumx) awarded a token.Nov 28 2020, 9:36 PM
xan2622 (xan2622) added a subscriber: xan2622 (xan2622).Jul 26 2022, 5:17 PM
xan2622 (xan2622) awarded a token.Jul 26 2022, 5:20 PM
Paul Larson (GeorgiaPacific) awarded a token.Jul 27 2022, 12:13 AM
Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
7 lines
2 lines
source/
blender/
blenkernel/
1 line
intern/
43 lines
editors/
render/
5 lines
space_image/
14 lines
2 lines
33 lines
2 lines
makesdna/
12 lines
4 lines
makesrna/
intern/
19 lines
11 lines
render/
extern/
include/
1 line
intern/
source/
8 lines

Diff 11320

View Options

release/scripts/startup/bl_ui/space_image.py

Loading...
View Options

release/scripts/startup/bl_ui/space_userpref.py

Loading...
View Options

source/blender/blenkernel/BKE_image.h

Loading...
View Options

source/blender/blenkernel/intern/image.c

Loading...
View Options

source/blender/editors/render/render_internal.c

Loading...
View Options

source/blender/editors/space_image/image_buttons.c

Loading...
View Options

source/blender/editors/space_image/image_intern.h

Loading...
View Options

source/blender/editors/space_image/image_ops.c

Loading...
View Options

source/blender/editors/space_image/space_image.c

Loading...
View Options

source/blender/makesdna/DNA_space_types.h

Loading...
View Options

source/blender/makesdna/DNA_userdef_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...
View Options

source/blender/makesrna/intern/rna_userdef.c

Loading...
View Options

source/blender/render/extern/include/RE_pipeline.h

Loading...
View Options

source/blender/render/intern/source/pipeline.c

Loading...