Changes to integrate grease pencil modifiers in Depsgraph
AbandonedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Jun 20 2018, 8:03 PM.

Details

Reviewers

Dalai Felinto (dfelinto)

Summary

The grease pencil modifiers are not evaluated and need to be integrated.

Diff Detail

Event Timeline

@Dalai Felinto (dfelinto) I think this could be the fix to integrate depsgraph

Antonio Vazquez (antoniov) mentioned this in D2889: Grease Pencil Branch (greasepencil-object).Jun 20 2018, 8:05 PM

Not totally sure if need changes in void DepsgraphRelationBuilder::build_object(Base *base, Object *object) too.

Dalai Felinto (dfelinto) added a subscriber: Sergey Sharybin (sergey).Jun 20 2018, 11:10 PM

I have added two functions for IDLink in commit 853da3babc05b4294f603021e74263b99d4fe970

I think the following functions need code to call the link functions, but I don't know how to do it.

in degbuilder_nodes.cc:

void DepsgraphNodeBuilder::build_object(int base_index,
                             Object *object,
                             eDepsNode_LinkedState_Type linked_state)

in deg_builder_relations.cc:

void DepsgraphRelationBuilder::build_object(Base *base, Object *object)

@Dalai Felinto (dfelinto) Could you do the fix for these two functions?

Edited: More changes in commit e584443af782 I think is this the right code, but could you review it?

AFAIR, grease pencil modifiers can point to other IDs. That means, you need to traverse those in order to pull all dependencies into the graph. See modifiers_foreachIDLink() in deg_builder_nodes.cc and deg_builder_relations.cc.